Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2436)

Unified Diff: core/src/fpdftext/fpdf_text.cpp

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/src/fpdftext/fpdf_text.cpp
diff --git a/core/src/fpdftext/fpdf_text.cpp b/core/src/fpdftext/fpdf_text.cpp
index 52fcb5abd7508f57354d6b8dd5e36b4c0840f31c..6aa411d7d7d8653eb18f2b488d04b6d1ed697fc4 100644
--- a/core/src/fpdftext/fpdf_text.cpp
+++ b/core/src/fpdftext/fpdf_text.cpp
@@ -104,9 +104,7 @@ void CTextPage::ProcessObject(CPDF_PageObject* pObject) {
InsertTextBox(NULL, char_origy, char_left, char_right, char_top,
char_bottom, spacew, fontsize_v, str, pFont);
}
- if (pPosArray) {
FX_Free(pPosArray);
- }
return;
}
FX_FLOAT ratio_h = fontsize_h / pText->m_TextState.GetFontSize();

Powered by Google App Engine
This is Rietveld 408576698