Don't bother checking pointers before delete[] and FX_Free().

core/src/fxcrt/fx_basic_maps.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fxcrt/fx_basic.h"
 #include "plex.h"
 
 static void ConstructElement(CFX_ByteString* pNewData) {
   new (pNewData) CFX_ByteString();
 }
 static void DestructElement(CFX_ByteString* pOldData) {
   pOldData->~CFX_ByteString();
 }
 CFX_MapPtrToPtr::CFX_MapPtrToPtr(int nBlockSize)
     : m_pHashTable(NULL),
       m_nHashTableSize(17),
       m_nCount(0),
       m_pFreeList(NULL),
       m_pBlocks(NULL),
       m_nBlockSize(nBlockSize) {
   ASSERT(m_nBlockSize > 0);
 }
 void CFX_MapPtrToPtr::RemoveAll() {
-  if (m_pHashTable) {
-    FX_Free(m_pHashTable);
-    m_pHashTable = NULL;
-  }
+  FX_Free(m_pHashTable);
+  m_pHashTable = NULL;
   m_nCount = 0;
   m_pFreeList = NULL;
   m_pBlocks->FreeDataChain();
   m_pBlocks = NULL;
 }
 CFX_MapPtrToPtr::~CFX_MapPtrToPtr() {
   RemoveAll();
   ASSERT(m_nCount == 0);
 }
 FX_DWORD CFX_MapPtrToPtr::HashKey(void* key) const {
@@ skipping 87 matching lines @@
   m_pFreeList = m_pFreeList->pNext;
   m_nCount++;
   ASSERT(m_nCount > 0);
   pAssoc->key = 0;
   pAssoc->value = 0;
   return pAssoc;
 }
 void CFX_MapPtrToPtr::InitHashTable(FX_DWORD nHashSize, FX_BOOL bAllocNow) {
   ASSERT(m_nCount == 0);
   ASSERT(nHashSize > 0);
-  if (m_pHashTable != NULL) {
-    FX_Free(m_pHashTable);
-    m_pHashTable = NULL;
-  }
+  FX_Free(m_pHashTable);
+  m_pHashTable = NULL;
   if (bAllocNow) {
     m_pHashTable = FX_Alloc(CAssoc*, nHashSize);
   }
   m_nHashTableSize = nHashSize;
 }
 FX_BOOL CFX_MapPtrToPtr::RemoveKey(void* key) {
   if (m_pHashTable == NULL) {
     return FALSE;
   }
   CAssoc** ppAssocPrev;
@@ skipping 163 matching lines @@
   if (pAssoc == NULL) {
     return FALSE;
   }
   rValue = pAssoc->value;
   return TRUE;
 }
 void CFX_MapByteStringToPtr::InitHashTable(FX_DWORD nHashSize,
                                            FX_BOOL bAllocNow) {
   ASSERT(m_nCount == 0);
   ASSERT(nHashSize > 0);
-  if (m_pHashTable != NULL) {
-    FX_Free(m_pHashTable);
-    m_pHashTable = NULL;
-  }
+  FX_Free(m_pHashTable);
+  m_pHashTable = NULL;
   if (bAllocNow) {
     m_pHashTable = FX_Alloc(CAssoc*, nHashSize);
   }
   m_nHashTableSize = nHashSize;
 }
 inline FX_DWORD CFX_MapByteStringToPtr::HashKey(
     const CFX_ByteStringC& key) const {
   FX_DWORD nHash = 0;
   int len = key.GetLength();
   const uint8_t* buf = key.GetPtr();
@@ skipping 269 matching lines @@
     } else {
       buf[mid].value = value;
       return;
     }
   }
   m_Buffer.InsertBlock(low * sizeof(_DWordPair), &pair, sizeof(_DWordPair));
 }
 void CFX_CMapDWordToDWord::EstimateSize(FX_DWORD size, FX_DWORD grow_by) {
   m_Buffer.EstimateSize(size, grow_by);
 }