Don't bother checking pointers before delete[] and FX_Free().

core/src/fxcrt/fx_basic_buffer.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fxcrt/fx_basic.h"
 FX_STRSIZE FX_ftoa(FX_FLOAT f, FX_CHAR* buf);
 CFX_BinaryBuf::CFX_BinaryBuf()
     : m_AllocStep(0), m_pBuffer(NULL), m_DataSize(0), m_AllocSize(0) {}
 CFX_BinaryBuf::CFX_BinaryBuf(FX_STRSIZE size)
     : m_AllocStep(0), m_DataSize(size), m_AllocSize(size) {
   m_pBuffer = FX_Alloc(uint8_t, size);
 }
 CFX_BinaryBuf::~CFX_BinaryBuf() {
-  if (m_pBuffer) {
-    FX_Free(m_pBuffer);
-  }
+  FX_Free(m_pBuffer);
 }
 void CFX_BinaryBuf::Delete(int start_index, int count) {
   if (!m_pBuffer || start_index < 0 || start_index + count > m_DataSize) {
     return;
   }
   FXSYS_memmove(m_pBuffer + start_index, m_pBuffer + start_index + count,
                 m_DataSize - start_index - count);
   m_DataSize -= count;
 }
 void CFX_BinaryBuf::Clear() {
   m_DataSize = 0;
 }
 void CFX_BinaryBuf::DetachBuffer() {
   m_DataSize = 0;
   m_pBuffer = NULL;
   m_AllocSize = 0;
 }
 void CFX_BinaryBuf::AttachData(void* buffer, FX_STRSIZE size) {
-  if (m_pBuffer) {
-    FX_Free(m_pBuffer);
-  }
+  FX_Free(m_pBuffer);
   m_DataSize = size;
   m_pBuffer = (uint8_t*)buffer;
   m_AllocSize = size;
 }
 void CFX_BinaryBuf::TakeOver(CFX_BinaryBuf& other) {
   AttachData(other.GetBuffer(), other.GetSize());
   other.DetachBuffer();
 }
 void CFX_BinaryBuf::EstimateSize(FX_STRSIZE size, FX_STRSIZE step) {
   m_AllocStep = step;
@@ skipping 201 matching lines @@
   if (bit_left) {
     result |= m_pData[byte_pos] >> (8 - bit_left);
   }
   m_BitPos += nBits;
   return result;
 }
 IFX_BufferArchive::IFX_BufferArchive(FX_STRSIZE size)
     : m_BufSize(size), m_pBuffer(NULL), m_Length(0) {}
 void IFX_BufferArchive::Clear() {
   m_Length = 0;
-  if (m_pBuffer) {
-    FX_Free(m_pBuffer);
-    m_pBuffer = NULL;
-  }
+  FX_Free(m_pBuffer);
+  m_pBuffer = NULL;
 }
 FX_BOOL IFX_BufferArchive::Flush() {
   FX_BOOL bRet = DoWork(m_pBuffer, m_Length);
   m_Length = 0;
   return bRet;
 }
 int32_t IFX_BufferArchive::AppendBlock(const void* pBuf, size_t size) {
   if (!pBuf || size < 1) {
     return 0;
   }
@@ skipping 54 matching lines @@
 }
 FX_BOOL CFX_FileBufferArchive::DoWork(const void* pBuf, size_t size) {
   if (!m_pFile) {
     return FALSE;
   }
   if (!pBuf || size < 1) {
     return TRUE;
   }
   return m_pFile->WriteBlock(pBuf, size);
 }