Don't bother checking pointers before delete[] and FX_Free().

core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_parser.h"
 #include "../../../include/fxcrt/fx_string.h"
 
 // static
@@ skipping 810 matching lines @@
 }
 CPDF_Stream::CPDF_Stream(uint8_t* pData, FX_DWORD size, CPDF_Dictionary* pDict)
     : CPDF_Object(PDFOBJ_STREAM) {
   m_pDict = pDict;
   m_dwSize = size;
   m_GenNum = (FX_DWORD)-1;
   m_pDataBuf = pData;
   m_pCryptoHandler = NULL;
 }
 CPDF_Stream::~CPDF_Stream() {
-  if (m_GenNum == (FX_DWORD)-1 && m_pDataBuf != NULL) {
+  if (m_GenNum == (FX_DWORD)-1) {
     FX_Free(m_pDataBuf);
   }
   if (m_pDict) {
     m_pDict->Release();
   }
 }
 void CPDF_Stream::InitStream(CPDF_Dictionary* pDict) {
   if (pDict) {
     if (m_pDict) {
       m_pDict->Release();
     }
     m_pDict = pDict;
   }
   if (m_GenNum == (FX_DWORD)-1) {
-    if (m_pDataBuf) {
-      FX_Free(m_pDataBuf);
-    }
+    FX_Free(m_pDataBuf);
   }
   m_GenNum = 0;
   m_pFile = NULL;
   m_pCryptoHandler = NULL;
   m_FileOffset = 0;
 }
 void CPDF_Stream::InitStream(uint8_t* pData,
                              FX_DWORD size,
                              CPDF_Dictionary* pDict) {
   InitStream(pDict);
   m_GenNum = (FX_DWORD)-1;
   m_pDataBuf = FX_Alloc(uint8_t, size);
   if (pData) {
     FXSYS_memcpy(m_pDataBuf, pData, size);
   }
   m_dwSize = size;
   if (m_pDict) {
     m_pDict->SetAtInteger(FX_BSTRC("Length"), size);
   }
 }
 void CPDF_Stream::SetData(const uint8_t* pData,
                           FX_DWORD size,
                           FX_BOOL bCompressed,
                           FX_BOOL bKeepBuf) {
   if (m_GenNum == (FX_DWORD)-1) {
-    if (m_pDataBuf) {
-      FX_Free(m_pDataBuf);
-    }
+    FX_Free(m_pDataBuf);
   } else {
     m_GenNum = (FX_DWORD)-1;
     m_pCryptoHandler = NULL;
   }
   if (bKeepBuf) {
     m_pDataBuf = (uint8_t*)pData;
   } else {
     m_pDataBuf = FX_Alloc(uint8_t, size);
     if (pData) {
       FXSYS_memcpy(m_pDataBuf, pData, size);
@@ skipping 176 matching lines @@
   if (pSrcData != pStream->m_pDataBuf && pSrcData != m_pData) {
     FX_Free(pSrcData);
   }
   if (pDecryptedData != pSrcData && pDecryptedData != m_pData) {
     FX_Free(pDecryptedData);
   }
   m_pSrcData = NULL;
   m_bNewBuf = m_pData != pStream->m_pDataBuf;
 }
 CPDF_StreamAcc::~CPDF_StreamAcc() {
-  if (m_bNewBuf && m_pData) {
+  if (m_bNewBuf) {
     FX_Free(m_pData);
   }
-  if (m_pSrcData) {
-    FX_Free(m_pSrcData);
-  }
+  FX_Free(m_pSrcData);
 }
 const uint8_t* CPDF_StreamAcc::GetData() const {
   if (m_bNewBuf) {
     return m_pData;
   }
   if (!m_pStream) {
     return NULL;
   }
   return m_pStream->m_pDataBuf;
 }
@@ skipping 123 matching lines @@
   }
   pObj->m_ObjNum = objnum;
   m_IndirectObjs.SetAt((void*)(uintptr_t)objnum, pObj);
   if (m_LastObjNum < objnum) {
     m_LastObjNum = objnum;
   }
 }
 FX_DWORD CPDF_IndirectObjects::GetLastObjNum() const {
   return m_LastObjNum;
 }