Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: fpdfsdk/src/fsdk_baseform.cpp

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../third_party/base/nonstd_unique_ptr.h" 7 #include "../../third_party/base/nonstd_unique_ptr.h"
8 #include "../include/fsdk_define.h" 8 #include "../include/fsdk_define.h"
9 #include "../include/fsdk_mgr.h" 9 #include "../include/fsdk_mgr.h"
10 #include "../include/fsdk_baseannot.h" 10 #include "../include/fsdk_baseannot.h"
(...skipping 2172 matching lines...) Expand 10 before | Expand all | Expand 10 after
2183 uint8_t* pBuffer = FdfBuffer.GetBuffer(); 2183 uint8_t* pBuffer = FdfBuffer.GetBuffer();
2184 FX_STRSIZE nBufSize = FdfBuffer.GetLength(); 2184 FX_STRSIZE nBufSize = FdfBuffer.GetLength();
2185 2185
2186 if (bUrlEncoded) { 2186 if (bUrlEncoded) {
2187 if (!FDFToURLEncodedData(pBuffer, nBufSize)) 2187 if (!FDFToURLEncodedData(pBuffer, nBufSize))
2188 return FALSE; 2188 return FALSE;
2189 } 2189 }
2190 2190
2191 pEnv->JS_docSubmitForm(pBuffer, nBufSize, sDestination.c_str()); 2191 pEnv->JS_docSubmitForm(pBuffer, nBufSize, sDestination.c_str());
2192 2192
2193 if (bUrlEncoded && pBuffer) { 2193 if (bUrlEncoded) {
2194 FX_Free(pBuffer); 2194 FX_Free(pBuffer);
2195 pBuffer = NULL; 2195 pBuffer = NULL;
2196 } 2196 }
2197 2197
2198 return TRUE; 2198 return TRUE;
2199 } 2199 }
2200 2200
2201 FX_BOOL CPDFSDK_InterForm::ExportFormToFDFTextBuf(CFX_ByteTextBuf& textBuf) { 2201 FX_BOOL CPDFSDK_InterForm::ExportFormToFDFTextBuf(CFX_ByteTextBuf& textBuf) {
2202 ASSERT(m_pInterForm != NULL); 2202 ASSERT(m_pInterForm != NULL);
2203 ASSERT(m_pDocument != NULL); 2203 ASSERT(m_pDocument != NULL);
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
2657 ASSERT(pAnnot != NULL); 2657 ASSERT(pAnnot != NULL);
2658 2658
2659 CPDF_Annot* pPDFAnnot = pAnnot->GetPDFAnnot(); 2659 CPDF_Annot* pPDFAnnot = pAnnot->GetPDFAnnot();
2660 ASSERT(pPDFAnnot != NULL); 2660 ASSERT(pPDFAnnot != NULL);
2661 2661
2662 CPDF_Rect rcAnnot; 2662 CPDF_Rect rcAnnot;
2663 pPDFAnnot->GetRect(rcAnnot); 2663 pPDFAnnot->GetRect(rcAnnot);
2664 2664
2665 return rcAnnot; 2665 return rcAnnot;
2666 } 2666 }
OLDNEW
« core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp ('K') | « fpdfsdk/src/fsdk_actionhandler.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698