Don't bother checking pointers before delete[] and FX_Free().

core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <limits.h>
 
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "../../../include/fpdfapi/fpdf_page.h"
@@ skipping 464 matching lines @@
   FX_DWORD m_SampleMax;
   CPDF_StreamAcc* m_pSampleStream;
 };
 CPDF_SampledFunc::CPDF_SampledFunc() {
   m_pSampleStream = NULL;
   m_pEncodeInfo = NULL;
   m_pDecodeInfo = NULL;
 }
 CPDF_SampledFunc::~CPDF_SampledFunc() {
   delete m_pSampleStream;
-  if (m_pEncodeInfo) {
     FX_Free(m_pEncodeInfo);
-  }
-  if (m_pDecodeInfo) {
     FX_Free(m_pDecodeInfo);
-  }
 }
 FX_BOOL CPDF_SampledFunc::v_Init(CPDF_Object* pObj) {
   if (pObj->GetType() != PDFOBJ_STREAM) {
     return FALSE;
   }
   CPDF_Stream* pStream = (CPDF_Stream*)pObj;
   CPDF_Dictionary* pDict = pStream->GetDict();
   CPDF_Array* pSize = pDict->GetArray(FX_BSTRC("Size"));
   CPDF_Array* pEncode = pDict->GetArray(FX_BSTRC("Encode"));
   CPDF_Array* pDecode = pDict->GetArray(FX_BSTRC("Decode"));
@@ skipping 156 matching lines @@
   FX_FLOAT m_Exponent;
   FX_FLOAT* m_pBeginValues;
   FX_FLOAT* m_pEndValues;
   int m_nOrigOutputs;
 };
 CPDF_ExpIntFunc::CPDF_ExpIntFunc() {
   m_pBeginValues = NULL;
   m_pEndValues = NULL;
 }
 CPDF_ExpIntFunc::~CPDF_ExpIntFunc() {
-  if (m_pBeginValues) {
     FX_Free(m_pBeginValues);
-  }
-  if (m_pEndValues) {
     FX_Free(m_pEndValues);
-  }
 }
 FX_BOOL CPDF_ExpIntFunc::v_Init(CPDF_Object* pObj) {
   CPDF_Dictionary* pDict = pObj->GetDict();
   if (pDict == NULL) {
     return FALSE;
   }
   CPDF_Array* pArray0 = pDict->GetArray(FX_BSTRC("C0"));
   if (m_nOutputs == 0) {
     m_nOutputs = 1;
     if (pArray0) {
@@ skipping 38 matching lines @@
 };
 CPDF_StitchFunc::CPDF_StitchFunc() {
   m_nSubs = 0;
   m_pSubFunctions = NULL;
   m_pBounds = NULL;
   m_pEncode = NULL;
 }
 CPDF_StitchFunc::~CPDF_StitchFunc() {
   for (int i = 0; i < m_nSubs; i++)
     delete m_pSubFunctions[i];
-  if (m_pSubFunctions) {
-    FX_Free(m_pSubFunctions);
-  }
-  if (m_pBounds) {
+  FX_Free(m_pSubFunctions);
     FX_Free(m_pBounds);
-  }
-  if (m_pEncode) {
     FX_Free(m_pEncode);
-  }
 }
 FX_BOOL CPDF_StitchFunc::v_Init(CPDF_Object* pObj) {
   CPDF_Dictionary* pDict = pObj->GetDict();
   if (pDict == NULL) {
     return FALSE;
   }
   CPDF_Array* pArray = pDict->GetArray(FX_BSTRC("Functions"));
   if (pArray == NULL) {
     return FALSE;
   }
@@ skipping 83 matching lines @@
     delete pFunc;
     return NULL;
   }
   return pFunc;
 }
 CPDF_Function::CPDF_Function() {
   m_pDomains = NULL;
   m_pRanges = NULL;
 }
 CPDF_Function::~CPDF_Function() {
-  if (m_pDomains) {
     FX_Free(m_pDomains);
     m_pDomains = NULL;

[Tom Sepez, 2015/08/14 21:21:34]

nit: Pointless NULL assignment(s).

[Lei Zhang, 2015/08/14 21:43:14]

Done.

-  }
-  if (m_pRanges) {
     FX_Free(m_pRanges);
     m_pRanges = NULL;
-  }
 }
 FX_BOOL CPDF_Function::Init(CPDF_Object* pObj) {
   CPDF_Dictionary* pDict;
   if (pObj->GetType() == PDFOBJ_STREAM) {
     pDict = ((CPDF_Stream*)pObj)->GetDict();
   } else {
     pDict = (CPDF_Dictionary*)pObj;
   }
   CPDF_Array* pDomains = pDict->GetArray(FX_BSTRC("Domain"));
   if (pDomains == NULL) {
@@ skipping 49 matching lines @@
     for (int i = 0; i < m_nOutputs; i++) {
       if (results[i] < m_pRanges[i * 2]) {
         results[i] = m_pRanges[i * 2];
       } else if (results[i] > m_pRanges[i * 2 + 1]) {
         results[i] = m_pRanges[i * 2 + 1];
       }
     }
   }
   return TRUE;
 }