Tool to convert RtcEventLog files to RtpDump format.

webrtc/test/rtp_file_writer.cc

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 22 matching lines @@
   }
   virtual ~RtpDumpWriter() {
     if (file_ != NULL) {
       fclose(file_);
       file_ = NULL;
     }
   }
 
   bool WritePacket(const RtpPacket* packet) override {
     uint16_t len = static_cast<uint16_t>(packet->length + kPacketHeaderSize);
-    RTC_CHECK_GE(packet->original_length, packet->length);

[kjellander_webrtc, 2015/09/17 14:49:36]

Can you explain why this check needs to go away?

[ivoc, 2015/09/17 14:53:29]

Of course, I added support for writing RTCP packets in the RTPdump format, and
for RTCP packets the original_length should be set to 0 (see for example the
plen field: http://www.cs.columbia.edu/irt/software/rtptools/#rtpdump ). So this
CHECK is preventing RTCP packets from being written.

[kjellander_webrtc, 2015/09/18 05:41:18]

Thanks for the explanation!

     uint16_t plen = static_cast<uint16_t>(packet->original_length);
     uint32_t offset = packet->time_ms;
     RTC_CHECK(WriteUint16(len));
     RTC_CHECK(WriteUint16(plen));
     RTC_CHECK(WriteUint32(offset));
     return fwrite(packet->data, sizeof(uint8_t), packet->length, file_) ==
            packet->length;
   }
 
  private:
@@ skipping 46 matching lines @@
   switch (format) {
     case kRtpDump:
       return new RtpDumpWriter(file);
   }
   fclose(file);
   return NULL;
 }
 
 }  // namespace test
 }  // namespace webrtc