Adjust talkback focus rect to stay within viewport size

Adjust talkback focus rect to stay within viewport size

In talkback mode the focus ring overlaps URL Bar on
scrolling beyond viewport area.
Adjusted focus rect top and bottom bounds to
fit within viewport region.

BUG=522404
Committed: https://crrev.com/c310358f0671828d89c7d41d6698221e88c58e4a
Cr-Commit-Position: refs/heads/master@{#344468}

[Swati, 2015-08-19 10:01:24]

swa.jaiswal@samsung.com changed reviewers:
+ ajith.v@samsung.com, r.ghatage@samsung.com

[Swati, 2015-08-19 10:01:25]

Please review the changes.

[AKV, 2015-08-19 10:20:45]

ajith.v@chromium.org changed reviewers:
+ ajith.v@chromium.org

[AKV, 2015-08-19 10:20:46]

Posted minor nits.

https://codereview.chromium.org/1297643003/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
(right):

https://codereview.chromium.org/1297643003/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java:836:
if (rect.top < viewportRectTop) {
if (rect.top < viewportRectTop) rect.top = viewportRectTop;
if (rect.bottom > viewportRectBottom) rect.bottom = viewportRectBottom;

[Swati, 2015-08-19 10:45:32]

Applied the changes.

[AKV, 2015-08-19 11:10:23]

peer review looks good to me!

[Swati, 2015-08-19 11:22:34]

swa.jaiswal@samsung.com changed reviewers:
+ dmazzoni@chromium.org
- ajith.v@chromium.org

[Swati, 2015-08-19 11:22:34]

Please review the changes.

Thank You.

[dmazzoni, 2015-08-19 16:02:04]

Thanks for the contribution. lgtm with a suggested change to the comment
wording.

https://codereview.chromium.org/1297643003/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java
(right):

https://codereview.chromium.org/1297643003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java:833:
// Adjust rect top & bottom coordinates based on viewport for handling scroll
scenarios.
Typically the word "clip" is used when adjusting a point or rect so that it's no
larger than another rect. So how about this comment:

// Clip the node's bounding rect to the viewport bounds.

[Swati, 2015-08-20 04:53:55]

Thank You.

Incorporated the change to comment.

[Swati, 2015-08-20 05:14:48]

The CQ bit was checked by swa.jaiswal@samsung.com

[Swati, 2015-08-20 05:14:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1297643003/#ps40001
(title: "Modified comment to being short and precise.")

[commit-bot: I haz the power, 2015-08-20 05:14:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297643003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297643003/40001

[commit-bot: I haz the power, 2015-08-20 06:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 06:06:30]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Swati, 2015-08-20 09:41:49]

The CQ bit was checked by swa.jaiswal@samsung.com

[commit-bot: I haz the power, 2015-08-20 09:41:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297643003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297643003/40001

[commit-bot: I haz the power, 2015-08-20 10:05:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-20 10:06:06]

Patchset 3 (id:??) landed as
https://crrev.com/c310358f0671828d89c7d41d6698221e88c58e4a
Cr-Commit-Position: refs/heads/master@{#344468}