Issue 129763002: linux_aura: Don't clear target vector in SelectionOwner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 129763002: linux_aura: Don't clear target vector in SelectionOwner. (Closed)

Created:
6 years, 11 months ago by Elliot Glaysher

Modified:
6 years, 11 months ago

Reviewers:
sadrul

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

linux_aura: Don't clear target vector in SelectionOwner. This was causing an intermittent crash in the SelectionClear unit tests, since it cleared the TARGETS atom out of the list of offered types BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243985

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	ui/base/x/selection_owner.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/base/x/selection_owner.cc	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sadrul

LGTM https://codereview.chromium.org/129763002/diff/1/ui/base/x/selection_owner.cc File ui/base/x/selection_owner.cc (right): https://codereview.chromium.org/129763002/diff/1/ui/base/x/selection_owner.cc#newcode83 ui/base/x/selection_owner.cc:83: RetrieveTargets(&targets); An alternate solution could be to targets.push_back(targets_atom); ...

6 years, 11 months ago (2014-01-09 13:07:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/129763002/1

6 years, 11 months ago (2014-01-09 18:33:01 UTC) #3

Message was sent while issue was closed.

Change committed as 243985

Expand Messages | Collapse Messages