Issue 1297593005: Remove unused code warnings found by clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1297593005: Remove unused code warnings found by clang. (Closed)

Created:
5 years, 4 months ago by Lei Zhang

Modified:
5 years, 4 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -3167 lines)			Patch
M	BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UTF16-H_0.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	core/src/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UTF16-H_5.cpp	View	1 chunk	+0 lines, -3084 lines	0 comments	Download
D	core/src/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UTF16-V_5.cpp	View	1 chunk	+0 lines, -75 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

Clang + Linux is warning free after this outside of third party code.

5 years, 4 months ago (2015-08-18 06:52:01 UTC) #2

Lei Zhang

5 years, 4 months ago (2015-08-18 19:24:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bcfcc4619017b7f70c84a582196763894cc72d24 (presubmit successful).