Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1297593004: Don't call Document::nodeWillRemoved() with a node in different document (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't call Document::nodeWillRemoved() with a node in different document This patch changes |ContainerNode::willRemoveChild()| not to call |Document::nodeWillRemoved()| for a node in different document since we assume |Document::nodeWillRemoved()| will be called for owner document. This situation can be happened when DOM mutation event handler moves a removing node to another document via |dispatchChildRemovalEvents()| call in |ContainerNode::willRemoveChild()| at L439. BUG=477584 TEST=LayoutTests/fast/dom/Range/range-dom-node-removed-assert.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200791

Patch Set 1 : 2015-08-18T15:40:27 #

Total comments: 3

Patch Set 2 : 2015-08-18T17:03:20 Changes for review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
A LayoutTests/fast/dom/Range/range-dom-node-removed-assert.html View 1 chunk +26 lines, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-18 07:42:24 UTC) #2
tkent
lgtm https://codereview.chromium.org/1297593004/diff/1/Source/core/dom/ContainerNode.cpp File Source/core/dom/ContainerNode.cpp (right): https://codereview.chromium.org/1297593004/diff/1/Source/core/dom/ContainerNode.cpp#newcode442 Source/core/dom/ContainerNode.cpp:442: // |child| is moved another document by DOM ...
5 years, 4 months ago (2015-08-18 07:49:58 UTC) #3
yosin_UTC9
Thanks! Committing... https://codereview.chromium.org/1297593004/diff/1/Source/core/dom/ContainerNode.cpp File Source/core/dom/ContainerNode.cpp (right): https://codereview.chromium.org/1297593004/diff/1/Source/core/dom/ContainerNode.cpp#newcode442 Source/core/dom/ContainerNode.cpp:442: // |child| is moved another document by ...
5 years, 4 months ago (2015-08-18 08:11:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297593004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297593004/20001
5 years, 4 months ago (2015-08-19 01:04:58 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 03:51:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200791

Powered by Google App Engine
This is Rietveld 408576698