Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: test_reflectable/.status

Issue 1297503006: Clarifies the status of implicit accessors; fixed several related bugs. (Closed) Base URL: https://github.com/dart-lang/reflectable.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test_reflectable/.status
diff --git a/test_reflectable/.status b/test_reflectable/.status
index 1ecb20bbcdc3638f39eaaee812823b151bca14d4..a4919d42f839d5a974a2f51069d4aa02bda6be1c 100644
--- a/test_reflectable/.status
+++ b/test_reflectable/.status
@@ -10,9 +10,9 @@ test/*_test: skip # Some needed mirror features not implemented by dart2js.
[ ($compiler == none && $runtime != dartium) || $compiler == dart2js || $compiler == dartanalyzer || $compiler == dart2analyzer]
build/test/new_instance_default_values_test: CompileTimeError # Issue #8
-build/test/parameter_mirrors_test: CompileTimeError # Missing implementation
+build/test/parameter_mirrors_test: CompileTimeError # Issue #8
sigurdm 2015/08/20 09:39:52 Maybe we should split this up into a test with the
eernst 2015/08/20 10:43:25 Yes. The problem emerged because I added code to i
sigurdm 2015/08/20 10:46:34 That would work too
[ ($compiler == none && $runtime == dartium) ]
build/test/new_instance_default_values_test: RuntimeError # Issue #8
-build/test/parameter_mirrors_test: RuntimeError # Missing implementation
+build/test/parameter_mirrors_test: RuntimeError # Issue #8

Powered by Google App Engine
This is Rietveld 408576698