Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1297503004: Adding Null check in onAuthRequired() for handling FTP requests (Closed)

Created:
5 years, 4 months ago by shiva.jm
Modified:
5 years, 3 months ago
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding Null check in onAuthRequired() for handling FTP requests statusCode was implemented in: https://code.google.com/p/chromium/issues/detail?id=447180 BUG=521296 Committed: https://crrev.com/1e571d6050004a98dc506f95f2faaa76f6045c74 Cr-Commit-Position: refs/heads/master@{#344433}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M extensions/browser/api/web_request/web_request_api.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
shiva.jm
pls have a look.
5 years, 4 months ago (2015-08-19 10:26:23 UTC) #2
not at google - send to devlin
lgtm https://codereview.chromium.org/1297503004/diff/1/extensions/browser/api/web_request/web_request_api.cc File extensions/browser/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/1297503004/diff/1/extensions/browser/api/web_request/web_request_api.cc#newcode1002 extensions/browser/api/web_request/web_request_api.cc:1002: request->response_headers()->response_code()); Make sure to run "git cl format" ...
5 years, 4 months ago (2015-08-19 14:43:25 UTC) #3
shiva.jm
updated with comments. pls have a look. https://codereview.chromium.org/1297503004/diff/1/extensions/browser/api/web_request/web_request_api.cc File extensions/browser/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/1297503004/diff/1/extensions/browser/api/web_request/web_request_api.cc#newcode1002 extensions/browser/api/web_request/web_request_api.cc:1002: request->response_headers()->response_code()); On ...
5 years, 4 months ago (2015-08-20 04:07:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297503004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297503004/20001
5 years, 4 months ago (2015-08-20 04:08:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/22132)
5 years, 4 months ago (2015-08-20 04:33:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297503004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297503004/20001
5 years, 4 months ago (2015-08-20 05:50:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-20 06:12:51 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1e571d6050004a98dc506f95f2faaa76f6045c74 Cr-Commit-Position: refs/heads/master@{#344433}
5 years, 4 months ago (2015-08-20 06:13:30 UTC) #13
cbentzel
On 2015/08/20 06:13:30, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
5 years, 4 months ago (2015-08-20 09:50:53 UTC) #14
cbentzel
On 2015/08/20 06:13:30, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
5 years, 4 months ago (2015-08-20 09:50:54 UTC) #15
cbentzel
5 years, 4 months ago (2015-08-20 09:51:24 UTC) #16
Message was sent while issue was closed.
On 2015/08/20 06:13:30, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/1e571d6050004a98dc506f95f2faaa76f6045c74
> Cr-Commit-Position: refs/heads/master@{#344433}

post-commit request: could you add a test which exercises this behavior?

Powered by Google App Engine
This is Rietveld 408576698