|
|
DescriptionAdding Null check in onAuthRequired() for handling FTP requests
statusCode was implemented in:
https://code.google.com/p/chromium/issues/detail?id=447180
BUG=521296
Committed: https://crrev.com/1e571d6050004a98dc506f95f2faaa76f6045c74
Cr-Commit-Position: refs/heads/master@{#344433}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #Messages
Total messages: 17 (6 generated)
shiva.jm@samsung.com changed reviewers: + battre@chromium.org, kalman@chromium.org, rockot@chromium.org
pls have a look.
lgtm https://codereview.chromium.org/1297503004/diff/1/extensions/browser/api/web_... File extensions/browser/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/1297503004/diff/1/extensions/browser/api/web_... extensions/browser/api/web_request/web_request_api.cc:1002: request->response_headers()->response_code()); Make sure to run "git cl format" before submitting this CL.
updated with comments. pls have a look. https://codereview.chromium.org/1297503004/diff/1/extensions/browser/api/web_... File extensions/browser/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/1297503004/diff/1/extensions/browser/api/web_... extensions/browser/api/web_request/web_request_api.cc:1002: request->response_headers()->response_code()); On 2015/08/19 14:43:25, kalman wrote: > Make sure to run "git cl format" before submitting this CL. Done.
The CQ bit was checked by shiva.jm@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org Link to the patchset: https://codereview.chromium.org/1297503004/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297503004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297503004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by shiva.jm@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297503004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297503004/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1e571d6050004a98dc506f95f2faaa76f6045c74 Cr-Commit-Position: refs/heads/master@{#344433}
Message was sent while issue was closed.
On 2015/08/20 06:13:30, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as > https://crrev.com/1e571d6050004a98dc506f95f2faaa76f6045c74 > Cr-Commit-Position: refs/heads/master@{#344433}
Message was sent while issue was closed.
On 2015/08/20 06:13:30, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as > https://crrev.com/1e571d6050004a98dc506f95f2faaa76f6045c74 > Cr-Commit-Position: refs/heads/master@{#344433}
Message was sent while issue was closed.
On 2015/08/20 06:13:30, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as > https://crrev.com/1e571d6050004a98dc506f95f2faaa76f6045c74 > Cr-Commit-Position: refs/heads/master@{#344433} post-commit request: could you add a test which exercises this behavior?
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted |