Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1297493002:
Oilpan: Remove Heap::s_heapSizePerPersistent (Closed)
|
Created:
5 years, 4 months ago by haraken Modified:
5 years, 1 month ago CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium) Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionOilpan: Remove Heap::s_heapSizePerPersistent
This CL removes Heap::s_heapSizePerPersistent and instead introduces
Heap::s_markedObjectSizeAtLastCompleteSweep.
This is a preparation CL for landing https://codereview.chromium.org/1272083003/.
This CL is just code refactoring and shouldn't change any GC heuristics.
BUG=475801
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200617
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Patch Set 5 : #Patch Set 6 : #Patch Set 7 : #Patch Set 8 : #
Messages
Total messages: 37 (20 generated)
haraken@chromium.org changed reviewers: + keishi@chromium.org, oilpan-reviews@chromium.org
PTAL
lgtm
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by haraken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org Link to the patchset: https://codereview.chromium.org/1297493002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297493002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by haraken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org Link to the patchset: https://codereview.chromium.org/1297493002/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297493002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297493002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by haraken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org Link to the patchset: https://codereview.chromium.org/1297493002/#ps80001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297493002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297493002/80001
The CQ bit was checked by haraken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org Link to the patchset: https://codereview.chromium.org/1297493002/#ps120001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297493002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297493002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by haraken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org Link to the patchset: https://codereview.chromium.org/1297493002/#ps140001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297493002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297493002/140001
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200617 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
