Issue 1297453002: Make standalone PDFium DEPS pull clang-format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1297453002: Make standalone PDFium DEPS pull clang-format. (Closed)

Created:
5 years, 4 months ago by Tom Sepez

Modified:
5 years, 4 months ago

Reviewers:
Nico

CC:
pdfium-reviews_googlegroups.com, Lei Zhang

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make standalone PDFium DEPS pull clang-format. R=thakis@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ae35176b8b3adf2e8c8b5f30eaad93c5f47187f1

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -1 line)			Patch
	M	DEPS	View		1 chunk	+35 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

lgtm, thanks :-) https://codereview.chromium.org/1297453002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1297453002/diff/1/DEPS#newcode42 DEPS:42: # A change to a .gyp, ...

5 years, 4 months ago (2015-08-13 22:39:57 UTC) #3

Tom Sepez

5 years, 4 months ago (2015-08-13 22:41:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ae35176b8b3adf2e8c8b5f30eaad93c5f47187f1 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages