Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 129743003: Remove notifications from MediaFileSystemRegistry. (Closed)

Created:
6 years, 11 months ago by Avi (use Gerrit)
Modified:
6 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)
Visibility:
Public.

Description

Remove notifications from MediaFileSystemRegistry. BUG=170921 TEST=everything still works Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244301

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 7

Patch Set 3 : nits #

Patch Set 4 : windows dislikes shortening to bool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -111 lines) Patch
M chrome/browser/media_galleries/media_file_system_registry.cc View 1 2 3 4 chunks +151 lines, -111 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
6 years, 11 months ago (2014-01-09 20:59:11 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/129743003/diff/40001/chrome/browser/media_galleries/media_file_system_registry.cc File chrome/browser/media_galleries/media_file_system_registry.cc (right): https://codereview.chromium.org/129743003/diff/40001/chrome/browser/media_galleries/media_file_system_registry.cc#newcode55 chrome/browser/media_galleries/media_file_system_registry.cc:55: // interested in. Once all of the RPHs ...
6 years, 11 months ago (2014-01-09 22:49:47 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/129743003/diff/40001/chrome/browser/media_galleries/media_file_system_registry.cc File chrome/browser/media_galleries/media_file_system_registry.cc (right): https://codereview.chromium.org/129743003/diff/40001/chrome/browser/media_galleries/media_file_system_registry.cc#newcode55 chrome/browser/media_galleries/media_file_system_registry.cc:55: // interested in. Once all of the RPHs have ...
6 years, 11 months ago (2014-01-10 15:42:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/129743003/190001
6 years, 11 months ago (2014-01-10 15:43:05 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 11 months ago (2014-01-10 16:21:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/129743003/230002
6 years, 11 months ago (2014-01-10 16:55:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/129743003/230002
6 years, 11 months ago (2014-01-10 23:20:06 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 01:58:47 UTC) #8
Message was sent while issue was closed.
Change committed as 244301

Powered by Google App Engine
This is Rietveld 408576698