Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 12974003: Improve TransportSecurityState data storage. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_nss.cc
===================================================================
--- net/socket/ssl_client_socket_nss.cc (revision 186438)
+++ net/socket/ssl_client_socket_nss.cc (working copy)
@@ -3476,7 +3476,7 @@
if (TransportSecurityState::IsBuildTimely()) {
result = ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN;
UMA_HISTOGRAM_BOOLEAN("Net.PublicKeyPinSuccess", false);
- TransportSecurityState::ReportUMAOnPinFailure(host);
+ domain_state.ReportUMAOnPinFailure();
palmer 2013/04/02 22:56:05 Re-reading the code around this line, which is my
unsafe 2013/04/03 05:21:42 Yeah, I think the build-age and reporting should m
}
} else {
UMA_HISTOGRAM_BOOLEAN("Net.PublicKeyPinSuccess", true);

Powered by Google App Engine
This is Rietveld 408576698