Improve TransportSecurityState data storage.

net/url_request/url_request_http_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 734 matching lines @@
   SetStatus(URLRequestStatus());
 
   const URLRequestContext* context = request_->context();
 
   if (result == ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN &&
       transaction_->GetResponseInfo() != NULL) {
     FraudulentCertificateReporter* reporter =
       context->fraudulent_certificate_reporter();
     if (reporter != NULL) {
       const SSLInfo& ssl_info = transaction_->GetResponseInfo()->ssl_info;
-      bool sni_available = SSLConfigService::IsSNIAvailable(
-          context->ssl_config_service());
       const std::string& host = request_->url().host();
 
-      reporter->SendReport(host, ssl_info, sni_available);
+      TransportSecurityState::DomainState domain_state;
+      const URLRequestContext* context = request_->context();
+      const bool report_to_google = context->transport_security_state() &&
+          context->transport_security_state()->GetDomainState(host,
+              SSLConfigService::IsSNIAvailable(context->ssl_config_service()),
+              &domain_state) && domain_state.IsGooglePinnedProperty();

[Ryan Sleevi, 2013/04/29 22:06:14]

style nit: The wrapping here is... a bit unreadable :)

const bool report_to_google =
    context->transport_security_state() &&
    context->transport_security_state()->GetDomainState(
        host,
        SSLConfigService::IsSNIAvailable(...),
        &domain_state) &&
    domain_state.IsGooglePinnedProperty();

Note how when wrapping multiple parameters to 4 line indent, you ALSO wrap the
first parameter ( "GetDomainState(host" ),  and similarly with the conditional
for "transport_security_state() &&"

[unsafe, 2013/04/30 10:42:57]

Done.

+      if (report_to_google)
+        reporter->SendReport(host, ssl_info);
     }
   }
 
   if (result == OK) {
     scoped_refptr<HttpResponseHeaders> headers = GetResponseHeaders();
     if (context->network_delegate()) {
       // Note that |this| may not be deleted until
       // |on_headers_received_callback_| or
       // |NetworkDelegate::URLRequestDestroyed()| has been called.
       int error = context->network_delegate()->
@@ skipping 804 matching lines @@
 
 void URLRequestHttpJob::NotifyURLRequestDestroyed() {
   awaiting_callback_ = false;
 }
 
 void URLRequestHttpJob::OnDetachRequest() {
   http_transaction_delegate_->OnDetachRequest();
 }
 
 }  // namespace net