sdk/lib/_internal/compiler/implementation/universe/universe.dart - Issue 12974002: Convert a == to a builtin identity check if the receiver type can only hit Object==.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/universe/universe.dart

Issue 12974002: Convert a == to a builtin identity check if the receiver type can only hit Object==. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/universe/universe.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/universe/universe.dart (revision 20306)

+++ sdk/lib/_internal/compiler/implementation/universe/universe.dart (working copy)

@@ -519,8 +519,8 @@

return false;

}

- if (mask.isNullable && compiler.backend.isNullImplementation(other)) {

- return appliesUntyped(element, compiler);

+ if (compiler.backend.isNullImplementation(other)) {

+ return mask.isNullable && appliesUntyped(element, compiler);

} else if (mask.isExact) {

return hasElementIn(self, element) && appliesUntyped(element, compiler);

} else if (mask.isSubclass) {

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/optimize.dart ('k') | tests/utils/dummy_compiler_test.dart » ('j') | no next file with comments »