Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1297393003: Update media/video-display-aspect-ratio.html expectation. (Closed)

Created:
5 years, 4 months ago by xhwang
Modified:
5 years, 4 months ago
Reviewers:
wolenetz
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update media/video-display-aspect-ratio.html expectation. BUG=523073 TEST=Fix test. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201069

Patch Set 1 #

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/media/video-display-aspect-ratio.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/video-display-aspect-ratio-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
wolenetz
lgtm % my guess is that your plan is to land the TestExpectations change first ...
5 years, 4 months ago (2015-08-21 01:09:02 UTC) #2
xhwang
comments addressed
5 years, 4 months ago (2015-08-24 16:31:24 UTC) #3
xhwang
On 2015/08/21 01:09:02, wolenetz wrote: > lgtm % my guess is that your plan is ...
5 years, 4 months ago (2015-08-24 16:31:57 UTC) #4
xhwang
5 years, 4 months ago (2015-08-24 16:32:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297393003/20001
5 years, 4 months ago (2015-08-24 16:32:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103148)
5 years, 4 months ago (2015-08-24 17:03:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297393003/20001
5 years, 4 months ago (2015-08-24 17:08:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103173)
5 years, 4 months ago (2015-08-24 17:33:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297393003/20001
5 years, 4 months ago (2015-08-24 18:01:32 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 18:37:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201069

Powered by Google App Engine
This is Rietveld 408576698