Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1297383003: Keep TextMetrics on the Oilpan heap always. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, dshwang, vivekg_samsung, blink-reviews-html_chromium.org, Justin Novosad, vivekg, dglazkov+blink, Rik, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Keep TextMetrics on the Oilpan heap always. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M Source/core/html/TextMetrics.h View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/html/TextMetrics.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 4 months ago (2015-08-20 21:21:37 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-21 00:18:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297383003/1
5 years, 4 months ago (2015-08-21 05:16:56 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 06:45:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200969

Powered by Google App Engine
This is Rietveld 408576698