Issue 1297383002: Revert of Have DM manually encode its .png outputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1297383002: Revert of Have DM manually encode its .png outputs. (Closed)

Created:
5 years, 4 months ago by mtklein_C

Modified:
5 years, 4 months ago

Reviewers:
msarett, stephana

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Have DM manually encode its .png outputs. (patchset #2 id:20001 of https://codereview.chromium.org/1304443002/ ) Reason for revert: derek + Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Debug Original issue's description: > Have DM manually encode its .png outputs. > > This eliminates some variability on various axes: different PNG encoders, different libpng versions, different formats (RGB, indexed), different unpremultiplication, different sRGB tags. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3cc0dfffb70c0bd08ed8899efcd2e98da86a6ec7 TBR=stephana@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/8c9a67ae4b635e063e8d3d15201442ed321de44e

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -73 lines)			Patch
	M	dm/DM.cpp	View		3 chunks	+16 lines, -72 lines	0 comments	Download
	M	gyp/dm.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mtklein_C

Created Revert of Have DM manually encode its .png outputs.

5 years, 4 months ago (2015-08-19 15:11:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297383002/1

5 years, 4 months ago (2015-08-19 15:11:30 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-19 15:11:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8c9a67ae4b635e063e8d3d15201442ed321de44e

Expand Messages | Collapse Messages