Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1297363004: cc: Move animate steps from proxies to LayerTreeHostImpl. (Closed)

Created:
5 years, 4 months ago by danakj
Modified:
5 years, 4 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, brianderson, piman, mithro-old
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move animate steps from proxies to LayerTreeHostImpl. Currently both proxies have early outs and call a few methods on LayerTreeHostImpl to do animations. This moves it all into a single Animate() call and consolidates the code in LayerTreeHostImpl. The old Animate() method took the current frame_time as an argument, but instead it can use it directly from the BeginFrameArgs. This required changes LayerTreeHostImpl tests that call Animate() to start/end impl frames to change the current frame time (which is more realistic). R=ajuma BUG=522658 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/12e2f6e4d40560f94d688e6969eb5d9358ead6e3 Cr-Commit-Position: refs/heads/master@{#344351}

Patch Set 1 #

Patch Set 2 : moveanimatecodetolthi: . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -86 lines) Patch
M cc/trees/layer_tree_host_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +16 lines, -3 lines 2 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 29 chunks +163 lines, -41 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 3 chunks +3 lines, -20 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
5 years, 4 months ago (2015-08-19 20:38:46 UTC) #1
ajuma
lgtm https://codereview.chromium.org/1297363004/diff/20001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1297363004/diff/20001/cc/trees/layer_tree_host_impl.cc#newcode426 cc/trees/layer_tree_host_impl.cc:426: // TODO(ajuma): Does this break things if first ...
5 years, 4 months ago (2015-08-19 21:05:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297363004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297363004/20001
5 years, 4 months ago (2015-08-19 21:08:50 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-19 22:25:51 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 22:27:09 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12e2f6e4d40560f94d688e6969eb5d9358ead6e3
Cr-Commit-Position: refs/heads/master@{#344351}

Powered by Google App Engine
This is Rietveld 408576698