|
|
Chromium Code Reviews|
Created:
5 years, 4 months ago by Abhishek Modified:
5 years, 4 months ago CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable sync_driver tests with GN
Added all the sync_driver missing unittest into gn.
BUG=519366
Committed: https://crrev.com/8de7d5899e2445e486c828847a10153358d54ecb
Cr-Commit-Position: refs/heads/master@{#344429}
Patch Set 1 #
Total comments: 2
Patch Set 2 : updated as commented #Messages
Total messages: 19 (7 generated)
abhishek.a21@samsung.com changed reviewers: + droger@chromium.org, r.kasibhatla@samsung.com
PTAL!
LGTM, thanks! https://codereview.chromium.org/1297353003/diff/1/components/sync_driver/BUIL... File components/sync_driver/BUILD.gn (right): https://codereview.chromium.org/1297353003/diff/1/components/sync_driver/BUIL... components/sync_driver/BUILD.gn:123: "//components/os_crypt", Alphabetical order: move this line up
The CQ bit was checked by droger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297353003/1
Updated as suggested. PTAL #2! https://codereview.chromium.org/1297353003/diff/1/components/sync_driver/BUIL... File components/sync_driver/BUILD.gn (right): https://codereview.chromium.org/1297353003/diff/1/components/sync_driver/BUIL... components/sync_driver/BUILD.gn:123: "//components/os_crypt", On 2015/08/19 13:45:31, droger wrote: > Alphabetical order: move this line up Done.
droger@chromium.org changed reviewers: + pavely@chromium.org
+pavely as OWNER
The CQ bit was checked by droger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297353003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
lgtm
I'm getting below errors:
--
[613/13727] CXX obj/ppapi/thunk/thunk/ppb_url_loader_thunk.o
FAILED: /b/build/goma/gomacc
../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-MMD -MF obj/components/view_manager/loader/android_loader.o.d
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_NOTIFICATIONS
-DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
-DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DDONT_EMBED_BUILD_METADATA
-DDCHECK_ALWAYS_ON=1 -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC
-DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_SUPERVISED_USERS=1
-DENABLE_AUTOFILL_DIALOG=1 -DUSE_PROPRIETARY_CODECS
-DV8_USE_EXTERNAL_STARTUP_DATA -DVIDEO_HOLE=1 -DMOBILE_SAFE_BROWSING
-DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1
-DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2
-D__GNU_SOURCE=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../..
-Igen -I../../third_party/mojo/src -Igen/third_party/mojo/src
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -march=armv7-a
-mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork
-fno-tree-sra -fno-caller-saves -funwind-tables -fPIC -pipe -ffunction-sections
-funwind-tables -fno-short-enums -finline-limit=64 -mfpu=vfpv3-d16 -Wall
-Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers
-Wno-type-limits -Wno-unused-local-typedefs
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include
-isystem../../third_party/android_tools/ndk/sources/android/support/include
-fvisibility=hidden
--sysroot=/b/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-16/arch-arm
-Os -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g1
-fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing
-Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor
-Wno-sign-promo -fno-rtti -fno-exceptions -c
../../components/view_manager/android_loader.cc -o
obj/components/view_manager/loader/android_loader.o
In file included from ../../components/view_manager/view_manager_app.h:16:0,
from ../../components/view_manager/android_loader.cc:7:
../../mojo/common/tracing_impl.h:11:67: fatal error:
mojo/services/tracing/public/interfaces/tracing.mojom.h: No such file or
directory
#include "mojo/services/tracing/public/interfaces/tracing.mojom.h"
^
compilation terminated.
ninja: build stopped: subcommand failed.
--
I think they are not related to my patch.
Trying again!
The CQ bit was checked by abhishek.a21@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org Link to the patchset: https://codereview.chromium.org/1297353003/#ps20001 (title: "updated as commented")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297353003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8de7d5899e2445e486c828847a10153358d54ecb Cr-Commit-Position: refs/heads/master@{#344429} |
