Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1297353003: Enable sync_driver tests with GN (Closed)

Created:
5 years, 4 months ago by Abhishek
Modified:
5 years, 4 months ago
Reviewers:
droger, r.kasibhatla, pavely
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable sync_driver tests with GN Added all the sync_driver missing unittest into gn. BUG=519366 Committed: https://crrev.com/8de7d5899e2445e486c828847a10153358d54ecb Cr-Commit-Position: refs/heads/master@{#344429}

Patch Set 1 #

Total comments: 2

Patch Set 2 : updated as commented #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M components/sync_driver/BUILD.gn View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Abhishek
PTAL!
5 years, 4 months ago (2015-08-19 13:41:06 UTC) #2
droger
LGTM, thanks! https://codereview.chromium.org/1297353003/diff/1/components/sync_driver/BUILD.gn File components/sync_driver/BUILD.gn (right): https://codereview.chromium.org/1297353003/diff/1/components/sync_driver/BUILD.gn#newcode123 components/sync_driver/BUILD.gn:123: "//components/os_crypt", Alphabetical order: move this line up
5 years, 4 months ago (2015-08-19 13:45:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297353003/1
5 years, 4 months ago (2015-08-19 13:45:46 UTC) #5
Abhishek
Updated as suggested. PTAL #2! https://codereview.chromium.org/1297353003/diff/1/components/sync_driver/BUILD.gn File components/sync_driver/BUILD.gn (right): https://codereview.chromium.org/1297353003/diff/1/components/sync_driver/BUILD.gn#newcode123 components/sync_driver/BUILD.gn:123: "//components/os_crypt", On 2015/08/19 13:45:31, ...
5 years, 4 months ago (2015-08-19 13:48:46 UTC) #6
droger
+pavely as OWNER
5 years, 4 months ago (2015-08-19 15:40:57 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297353003/20001
5 years, 4 months ago (2015-08-19 15:42:03 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/121736)
5 years, 4 months ago (2015-08-19 15:51:52 UTC) #12
pavely
lgtm
5 years, 4 months ago (2015-08-19 17:22:13 UTC) #13
Abhishek
I'm getting below errors: -- [613/13727] CXX obj/ppapi/thunk/thunk/ppb_url_loader_thunk.o FAILED: /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/components/view_manager/loader/android_loader.o.d -DV8_DEPRECATION_WARNINGS ...
5 years, 4 months ago (2015-08-20 05:03:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297353003/20001
5 years, 4 months ago (2015-08-20 05:03:43 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-20 05:14:00 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 05:14:36 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8de7d5899e2445e486c828847a10153358d54ecb
Cr-Commit-Position: refs/heads/master@{#344429}

Powered by Google App Engine
This is Rietveld 408576698