Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp - Issue 1297323002: Do not create scrollbars if the subtree is invisible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

Issue 1297323002: Do not create scrollbars if the subtree is invisible. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add layout test. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/compositing/animation/hidden-animated-layer-should-not-have-scrollbars-expected.html ('K') | « LayoutTests/compositing/animation/hidden-animated-layer-should-not-have-scrollbars-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

diff --git a/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp b/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

index a81670428299823469018edffe6d78998cf4a5be..0952bbe6d15e5477e55d00173cbf0fec0c0f93a4 100644

--- a/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

+++ b/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

@@ -1286,6 +1286,12 @@ bool CompositedDeprecatedPaintLayerMapping::toggleScrollbarLayerIfNeeded(OwnPtr<

bool CompositedDeprecatedPaintLayerMapping::updateOverflowControlsLayers(bool needsHorizontalScrollbarLayer, bool needsVerticalScrollbarLayer, bool needsScrollCornerLayer, bool needsAncestorClip)

{

+ // If the subtree is invisible, we don't actually need scrollbar layers.

+ bool invisible = m_owningLayer.subtreeIsInvisible();

+ needsHorizontalScrollbarLayer &= !invisible;

+ needsVerticalScrollbarLayer &= !invisible;

+ needsScrollCornerLayer &= !invisible;

bool horizontalScrollbarLayerChanged = toggleScrollbarLayerIfNeeded(m_layerForHorizontalScrollbar, needsHorizontalScrollbarLayer, CompositingReasonLayerForHorizontalScrollbar);

bool verticalScrollbarLayerChanged = toggleScrollbarLayerIfNeeded(m_layerForVerticalScrollbar, needsVerticalScrollbarLayer, CompositingReasonLayerForVerticalScrollbar);

bool scrollCornerLayerChanged = toggleScrollbarLayerIfNeeded(m_layerForScrollCorner, needsScrollCornerLayer, CompositingReasonLayerForScrollCorner);