runtime/vm/service/client.dart - Issue 1297313005: Fix the error response for bad isolate ids, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service/client.dart

Issue 1297313005: Fix the error response for bad isolate ids, etc. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/service/client.dart

diff --git a/runtime/vm/service/client.dart b/runtime/vm/service/client.dart

index c8a374a9aa70969b5c9ec32ffab08d2ff30c7126..1ac2a23c6599195138fe76bef2761d586bd58bbd 100644

--- a/runtime/vm/service/client.dart

+++ b/runtime/vm/service/client.dart

@@ -29,7 +29,8 @@ abstract class Client {

post(response);

});

} catch (e, st) {

- message.setErrorResponse('Internal error: $e');

+ message.setErrorResponse(

+ kInternalError, 'Unexpected exception:$e\n$st');

post(message.response);

}