Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1297273003: Roll Android tools to Android M SDK. (Closed)

Created:
5 years, 4 months ago by aurimas (slooooooooow)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Android tools to Android M SDK. Android SDK tools 24.3.3 -> 24.3.4 Android Platform tools 22 -> 23 Android SDK build tools 22 -> 23 Android SDK 5.1.1 (API 22) -> 6.0 (API 23) Android Support Library -> 23.0.0 This also rolls: Reland x86 toolchain from NDK r10e with a fix of "-mstackrealign" flag. Add GCM to the Google Play Services Library. BUG=522182, 521527

Patch Set 1 #

Patch Set 2 : Added needed fixes for NDK roll #

Patch Set 3 : Fix sha1 #

Patch Set 4 : Fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 chunks +8 lines, -2 lines 0 comments Download
M build/config/android/config.gni View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
aurimas (slooooooooow)
PTAL
5 years, 4 months ago (2015-08-18 22:55:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297273003/1
5 years, 4 months ago (2015-08-18 22:55:55 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/108620) android_chromium_gn_compile_dbg on ...
5 years, 4 months ago (2015-08-18 22:59:47 UTC) #6
Nico
"Reland x86 toolchain from NDK r10e." <- isn't this blocked on…uh, something? I remember fdegans ...
5 years, 4 months ago (2015-08-18 23:00:04 UTC) #7
Fabrice (no longer in Chrome)
On 2015/08/18 23:00:04, Nico wrote: > "Reland x86 toolchain from NDK r10e." <- isn't this ...
5 years, 4 months ago (2015-08-18 23:05:41 UTC) #8
aurimas (slooooooooow)
On 2015/08/18 at 23:05:41, fdegans wrote: > On 2015/08/18 23:00:04, Nico wrote: > > "Reland ...
5 years, 4 months ago (2015-08-18 23:16:41 UTC) #9
Nico
On 2015/08/18 23:16:41, aurimas wrote: > On 2015/08/18 at 23:05:41, fdegans wrote: > > On ...
5 years, 4 months ago (2015-08-18 23:27:03 UTC) #10
aurimas (slooooooooow)
thakis: please take another look, I merged the fixes from issue 1300633002 into this CL.
5 years, 4 months ago (2015-08-19 00:54:32 UTC) #12
Nico
lgtm, good luck!
5 years, 4 months ago (2015-08-19 16:04:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297273003/20001
5 years, 4 months ago (2015-08-19 16:10:52 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/109003) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-19 16:14:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297273003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297273003/40001
5 years, 4 months ago (2015-08-19 16:27:29 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/121762)
5 years, 4 months ago (2015-08-19 16:33:55 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297273003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297273003/60001
5 years, 4 months ago (2015-08-19 16:36:29 UTC) #25
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:48:41 UTC) #27
Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

Powered by Google App Engine
This is Rietveld 408576698