Issue 1297253002: [es6] Handle unicode escapes before checking for keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1297253002: [es6] Handle unicode escapes before checking for keywords (Closed)

Created:
5 years, 4 months ago by adamk

Modified:
5 years ago

Reviewers:

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[es6] Handle unicode escapes before checking for keywords This doesn't quite match the spec, but does match Firefox. There is probably more cleanup that could be done to reduce code duplication in this part of the Scanner, but this is the smallest patch that allows us to pass the test262 tests. BUG=v8:1972, v8:2222 LOG=n

Patch Set 1 #

Patch Set 2 : Skip mozilla test #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -77 lines)			Patch
M	src/scanner.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/scanner.cc	View		4 chunks	+9 lines, -4 lines	0 comments	Download
M	test/mozilla/mozilla.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/test262-es6/test262-es6.status	View		1 chunk	+0 lines, -72 lines	0 comments	Download