src/mips/disasm-mips.cc - Issue 1297183002: MIPS: Fix bug in disassembler for JALR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/disasm-mips.cc

Issue 1297183002: MIPS: Fix bug in disassembler for JALR (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/disasm-mips.cc

diff --git a/src/mips/disasm-mips.cc b/src/mips/disasm-mips.cc

index 89e95725f9afff3bbffa7dbb48769c2edbcf0865..6028e90b4410a5a479fe51414ac5be9977b33b37 100644

--- a/src/mips/disasm-mips.cc

+++ b/src/mips/disasm-mips.cc

@@ -987,7 +987,7 @@ void Decoder::DecodeTypeRegisterSPECIAL(Instruction* instr) {

Format(instr, "jr 'rs");

break;

case JALR:

- Format(instr, "jalr 'rs");

+ Format(instr, "jalr 'rs, 'rd");

break;

case SLL:

if (0x0 == static_cast<int>(instr->InstructionBits()))

« no previous file with comments | « no previous file | src/mips64/disasm-mips64.cc » ('j') | no next file with comments »