Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1297163002: Add URL permission to image loader to use analytics. (Closed)

Created:
5 years, 4 months ago by hirono
Modified:
5 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add URL permission to image loader to use analytics. BUG=516250 TEST=None Committed: https://crrev.com/f8b4519cadf7dea1e6c6c5337afc5da5e73e5548 Cr-Commit-Position: refs/heads/master@{#343849}

Patch Set 1 #

Patch Set 2 : Sort lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/image_loader/manifest.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL, thanks!
5 years, 4 months ago (2015-08-18 07:16:24 UTC) #2
fukino
lgtm!
5 years, 4 months ago (2015-08-18 07:22:51 UTC) #3
hirono
Thank you!
5 years, 4 months ago (2015-08-18 07:26:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297163002/20001
5 years, 4 months ago (2015-08-18 07:26:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 07:39:34 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 07:40:14 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f8b4519cadf7dea1e6c6c5337afc5da5e73e5548
Cr-Commit-Position: refs/heads/master@{#343849}

Powered by Google App Engine
This is Rietveld 408576698