Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1297153002: Version 4.5.103.23 (cherry-pick) (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
CC:
v8-dev, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.5
Target Ref:
refs/pending/branch-heads/4.5
Project:
v8
Visibility:
Public.

Description

Version 4.5.103.23 (cherry-pick) Merged 0752abb11453a3f1ea1d4eecf3f9068b6f599e4d Merged b528d0772bba9bc378c9cc18f624513ccfc7f8e8 Merged 869ab06ea5165ce0dc01396150a110478f8a3e42 Merged 9d7ebcf7f508b987464575b481476ce0a49d98b1 Merged da97af0d016aa69b78551de6b953f0624e8d6792 Merged e296644f953f5af906483abaa0965818c5369dd9 Merged 1345f811bf6a3ab9376cfbed6f08084662b32a4d Extract function to compute mutator utilization. Use conservative estimate for GC speed instead of bailing out when computing mutator utilization. GC: Refactor incremental marking steps w/ deadline into a separate call Reland: GC: Refactor public incremental marking interface in heap Fix idle step marking after 9d7ebc. Partially revert https://crrev.com/7e53749df0a10f475404e86ef0ca8df02bb79e7a Make sure that memory reducer makes progress in incremental marking even if there are no idle notifications. BUG=chromium:502247, chromium:515873, chromium:517468, chromium:520841 LOG=N R=hablich@chromium.org, mlippautz@chromium.org, jkummerow@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/b9b42f9020b693bfa25510a9e1e2c1da57eeb263

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -36 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.h View 2 chunks +7 lines, -0 lines 1 comment Download
M src/heap/gc-tracer.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/heap/heap.h View 3 chunks +21 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 7 chunks +108 lines, -27 lines 0 comments Download
M src/heap/incremental-marking.h View 4 chunks +22 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 4 chunks +20 lines, -4 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 chunk +24 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-18 05:49:23 UTC) #1
Michael Lippautz
frightened lgtm https://codereview.chromium.org/1297153002/diff/1/src/heap/gc-tracer.h File src/heap/gc-tracer.h (right): https://codereview.chromium.org/1297153002/diff/1/src/heap/gc-tracer.h#newcode414 src/heap/gc-tracer.h:414: // the last five seconds. Something for ...
5 years, 4 months ago (2015-08-18 06:53:05 UTC) #2
Michael Hablich
On 2015/08/18 06:53:05, Michael Lippautz wrote: > frightened lgtm > > https://codereview.chromium.org/1297153002/diff/1/src/heap/gc-tracer.h > File src/heap/gc-tracer.h ...
5 years, 4 months ago (2015-08-18 06:54:52 UTC) #3
Hannes Payer (out of office)
Committed patchset #1 (id:1) manually as b9b42f9020b693bfa25510a9e1e2c1da57eeb263.
5 years, 4 months ago (2015-08-18 07:42:53 UTC) #4
Michael Hablich
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1308363002/ by hablich@chromium.org. ...
5 years, 4 months ago (2015-08-24 12:23:51 UTC) #5
Michael Hablich
5 years, 4 months ago (2015-08-24 12:41:15 UTC) #6
Message was sent while issue was closed.
On 2015/08/24 12:23:51, Hablich wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1308363002/ by mailto:hablich@chromium.org.
> 
> The reason for reverting is: One of the merged CLs is the culprit for
> https://code.google.com/p/chromium/issues/detail?id=519319. .

Real revert at https://codereview.chromium.org/1314603002/

Powered by Google App Engine
This is Rietveld 408576698