xfa/src/fxgraphics/src/fx_graphics.cpp - Issue 1297083002: Merge to XFA: Cleanup CFX_UnicodeEncoding and remove IFX_FontEncoding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxgraphics/src/fx_graphics.cpp

Issue 1297083002: Merge to XFA: Cleanup CFX_UnicodeEncoding and remove IFX_FontEncoding. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/src/fxgraphics/src/fx_graphics.cpp

diff --git a/xfa/src/fxgraphics/src/fx_graphics.cpp b/xfa/src/fxgraphics/src/fx_graphics.cpp

index c5eac42e87c8636d484cbd5e7eed04ecc1dae02d..e223a74921fc66ba8893865600f0ea77060f5b93 100644

--- a/xfa/src/fxgraphics/src/fx_graphics.cpp

+++ b/xfa/src/fxgraphics/src/fx_graphics.cpp

@@ -1098,7 +1098,7 @@ FX_ERR CFX_Graphics::CalcTextInfo(const CFX_WideString& text,

FX_DWORD* charCodes,

FXTEXT_CHARPOS* charPos,

CFX_RectF& rect) {

- IFX_FontEncoding* encoding = FXGE_CreateUnicodeEncoding(_info._font);

+ CFX_UnicodeEncoding* encoding = new CFX_UnicodeEncoding(_info._font);

Tom Sepez 2015/08/17 23:49:29 same here.

Lei Zhang 2015/08/18 01:36:39 Done.

int32_t length = text.GetLength();

FX_FLOAT penX = (FX_FLOAT)rect.left;

FX_FLOAT penY = (FX_FLOAT)rect.top;

« xfa/src/fxbarcode/oned/BC_OneDimWriter.cpp ('K') | « xfa/src/fxbarcode/oned/BC_OneDimWriter.cpp ('k') | no next file » | no next file with comments »