android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java - Issue 1297073004: Fix various errorprone warnings and errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java

Issue 1297073004: Fix various errorprone warnings and errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java » ('j') | remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java

index 1efcf00cc7de162700cc914ccf02be239ec14fea..c1e67f95527327c3d226f5635e3eb9519b03d114 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java

@@ -45,7 +45,7 @@ public class PostMessageTest extends AwTestBase {

private String mData;

private String mOrigin;

private int[] mPorts;

- private Object mLock = new Object();

+ private final Object mLock = new Object();

@JavascriptInterface

public void setMessageParams(String data, String origin, int[] ports) {

@@ -526,7 +526,7 @@ public class PostMessageTest extends AwTestBase {

private static class ChannelContainer {

private boolean mReady;

private AwMessagePort[] mChannel;

- private Object mLock = new Object();

+ private final Object mLock = new Object();

private String mMessage = "";

private int mCount;

private int mWaitCount;

@@ -819,7 +819,7 @@ public class PostMessageTest extends AwTestBase {

private boolean mReady;

private AwMessagePort mPort;

- private Object mLock = new Object();

+ private final Object mLock = new Object();

public TestMessagePort(AwMessagePortService service) {

super(service);