remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java - Issue 1297073004: Fix various errorprone warnings and errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java

Issue 1297073004: Fix various errorprone warnings and errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove third_party/mojo/src change. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java ('K') | « content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java ('k') | remoting/android/java/src/org/chromium/chromoting/DesktopView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java

diff --git a/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java b/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java

index 33aa5e853a37cf73d9744787a1d9938eabe171b0..2a27ba54a5de44f769ea975b496ff58eb8762fdc 100644

--- a/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java

+++ b/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java

@@ -125,11 +125,11 @@ public class CardboardDesktopRenderer implements CardboardView.StereoRenderer {

private int mEyePointCombinedMatrixHandle;

/** Lock to allow multithreaded access to mReloadTexture. */

- private Object mReloadTextureLock = new Object();

+ private final Object mReloadTextureLock = new Object();

// Lock for eye position related operations.

// This protects access to mEyePositionVector as well as mDesktop{Height/Width}Pixels.

- private Object mEyePositionLock = new Object();

+ private final Object mEyePositionLock = new Object();

private int mDesktopHeightPixels;

private int mDesktopWidthPixels;