android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java - Issue 1297073004: Fix various errorprone warnings and errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java

Issue 1297073004: Fix various errorprone warnings and errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove third_party/mojo/src change. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwMessagePort.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java » ('j') | base/android/javatests/src/org/chromium/base/ObserverListTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java b/android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java

index d9057a901f83a64377bd802671101311b861929a..eec71e1e59ad6d5300647d29aa0e53d6a36c2ef2 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java

@@ -46,7 +46,7 @@ public class AwMessagePortService {

// A thread safe storage for Message Ports.

private static class MessagePortStorage {

private SparseArray<AwMessagePort> mMessagePorts = new SparseArray<AwMessagePort>();

- private Object mLock = new Object();

+ private final Object mLock = new Object();

public void remove(int portId) {

synchronized (mLock) {