Regenerate LCD text blobs if GrPaint's color changes, not SkPaint.

Regenerate LCD text blobs if GrPaint's color changes, not SkPaint.

The GrPaint's color takes into account shaders and color filters, so is a
more accurate picture of the color state.

BUG=chromium:511787
Committed: https://skia.googlesource.com/skia/+/0628a52b0cd11a7d5e3415f85c8b8d7cfa655151

[jvanverth1, 2015-08-18 14:19:52]

jvanverth@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-08-18 14:25:52]

lgtm + nit

https://codereview.chromium.org/1297053004/diff/1/src/gpu/GrAtlasTextContext.cpp
File src/gpu/GrAtlasTextContext.cpp (right):

https://codereview.chromium.org/1297053004/diff/1/src/gpu/GrAtlasTextContext....
src/gpu/GrAtlasTextContext.cpp:492: cacheBlob->fPaintColor = color;
Could we put a comment here explaining that this is the GrPaint color, and it is
used to know if we have to regenerate LCD Textblobs.  We use this vs the SkPaint
color because this color has the colorfilter applied.

[jvanverth1, 2015-08-18 14:37:53]

https://codereview.chromium.org/1297053004/diff/1/src/gpu/GrAtlasTextContext.cpp
File src/gpu/GrAtlasTextContext.cpp (right):

https://codereview.chromium.org/1297053004/diff/1/src/gpu/GrAtlasTextContext....
src/gpu/GrAtlasTextContext.cpp:492: cacheBlob->fPaintColor = color;
On 2015/08/18 14:25:52, joshualitt wrote:
> Could we put a comment here explaining that this is the GrPaint color, and it
is
> used to know if we have to regenerate LCD Textblobs.  We use this vs the
SkPaint
> color because this color has the colorfilter applied.

Done.

[jvanverth1, 2015-08-18 14:37:57]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2015-08-18 14:37:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/1297053004/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2015-08-18 14:38:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297053004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297053004/20001

[commit-bot: I haz the power, 2015-08-18 14:44:25]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0628a52b0cd11a7d5e3415f85c8b8d7cfa655151