Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1297023003: [Android] Roll android_tools to Android M SDK. (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, kerz_chromium, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Roll android_tools to Android M SDK. Partially stolen from https://codereview.chromium.org/1297273003/ Android SDK tools 24.3.3 -> 24.3.4 Android Platform tools 22 -> 23 Android SDK build tools 22 -> 23 Android SDK 5.1.1 (API 22) -> 6.0 (API 23) Android Support Library -> 23.0.0 This also rolls: Reland x86 toolchain from NDK r10e with a fix of "-mstackrealign" flag. Add GCM to the Google Play Services Library. BUG=522182, 521527 TBR=sievers@chromium.org NOTRY=true patch from issue 1297273003 at patchset 60001 (http://crrev.com/1297273003#ps60001) Committed: https://crrev.com/0d414de1c4a951509b5e8a0fc75e8dbba4c0e22b Cr-Commit-Position: refs/heads/master@{#344409}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix proguard + gn #

Patch Set 3 : remove net_test_extra_libs #

Patch Set 4 : fix builds #

Patch Set 5 : neverlink legacy_http_javalib #

Patch Set 6 : update SDK version in pylib #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -27 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/constants/__init__.py View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M build/common.gypi View 2 chunks +8 lines, -2 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/java/proguard.flags View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/shell/java/proguard.flags View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/content.gyp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/android/BUILD.gn View 1 2 chunks +1 line, -4 lines 0 comments Download
M net/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M net/net.gyp View 1 2 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
jbudorick
ptal: aurimas: anything dtrainor: chrome/ mmenke: net/ kerz: fyi https://codereview.chromium.org/1297023003/diff/1/net/net.gyp File net/net.gyp (right): https://codereview.chromium.org/1297023003/diff/1/net/net.gyp#newcode10 net/net.gyp:10: ...
5 years, 4 months ago (2015-08-19 20:22:48 UTC) #2
jbudorick
https://codereview.chromium.org/1297023003/diff/1/net/net.gyp File net/net.gyp (right): https://codereview.chromium.org/1297023003/diff/1/net/net.gyp#newcode10 net/net.gyp:10: 'net_test_extra_libs': [], On 2015/08/19 at 20:22:47, jbudorick wrote: > ...
5 years, 4 months ago (2015-08-19 20:23:24 UTC) #3
David Trainor- moved to gerrit
chrome/ lgtm.
5 years, 4 months ago (2015-08-19 21:03:05 UTC) #4
aurimas (slooooooooow)
lgtm
5 years, 4 months ago (2015-08-19 21:05:29 UTC) #5
mmenke
On 2015/08/19 21:05:29, aurimas wrote: > lgtm net/ LGTM
5 years, 4 months ago (2015-08-19 21:06:00 UTC) #6
jbudorick
+sievers for content/ OWNERS
5 years, 4 months ago (2015-08-19 22:46:16 UTC) #8
no sievers
On 2015/08/19 22:46:16, jbudorick wrote: > +sievers for content/ OWNERS lgtm
5 years, 4 months ago (2015-08-19 23:42:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297023003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297023003/100001
5 years, 4 months ago (2015-08-20 00:01:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297023003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297023003/100001
5 years, 4 months ago (2015-08-20 02:18:28 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 4 months ago (2015-08-20 02:23:42 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 02:24:56 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/0d414de1c4a951509b5e8a0fc75e8dbba4c0e22b
Cr-Commit-Position: refs/heads/master@{#344409}

Powered by Google App Engine
This is Rietveld 408576698