Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 1297013002: remove unused code (Closed)

Created:
5 years, 4 months ago by caryclark
Modified:
5 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove a little more unused code #

Patch Set 3 : fix fuzz test failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -56 lines) Patch
M src/pathops/SkDLineIntersection.cpp View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M src/pathops/SkIntersections.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/pathops/SkIntersections.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsConic.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsLine.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsLine.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M src/pathops/SkPathOpsQuad.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/PathOpsDLineTest.cpp View 1 2 chunks +0 lines, -16 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297013002/1
5 years, 4 months ago (2015-08-17 16:17:33 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-17 16:17:34 UTC) #3
mtklein
LGTM
5 years, 4 months ago (2015-08-17 16:19:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/5071) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 4 months ago (2015-08-17 16:19:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297013002/20001
5 years, 4 months ago (2015-08-17 16:55:04 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 17:01:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6a91ad22a41cd5f5677d9adbfec851f6464f3f0e

Powered by Google App Engine
This is Rietveld 408576698