Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1296993002: Expose new optional Input.SynthesizeRepeatingScroll parameters (Closed)

Created:
5 years, 4 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 4 months ago
Reviewers:
Sami, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose new optional Input.SynthesizeRepeatingScroll parameters Patch 2 of 4 to fix the overly long delay between each scroll in smoothness.scrolling_tough_ad_cases caused by the render thread being unresponsive. Patch 1: https://codereview.chromium.org/1299643004/ Patch 3: https://codereview.chromium.org/1291513004/ Patch 4: https://codereview.chromium.org/1285133008/ BUG=510398 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200723

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/devtools/protocol.json View 1 chunk +4 lines, -1 line 3 comments Download

Messages

Total messages: 10 (3 generated)
alex clarke (OOO till 29th)
5 years, 4 months ago (2015-08-17 15:48:06 UTC) #2
Sami
https://codereview.chromium.org/1296993002/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1296993002/diff/1/Source/devtools/protocol.json#newcode4522 Source/devtools/protocol.json:4522: { "name": "repeatCount", "type": "integer", "optional": true, "description": "The ...
5 years, 4 months ago (2015-08-17 16:40:42 UTC) #3
alex clarke (OOO till 29th)
pfeldman@chromium.org: Please review changes in
5 years, 4 months ago (2015-08-17 16:42:45 UTC) #5
pfeldman
lgtm https://codereview.chromium.org/1296993002/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1296993002/diff/1/Source/devtools/protocol.json#newcode4522 Source/devtools/protocol.json:4522: { "name": "repeatCount", "type": "integer", "optional": true, "description": ...
5 years, 4 months ago (2015-08-17 17:46:30 UTC) #6
alex clarke (OOO till 29th)
https://codereview.chromium.org/1296993002/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1296993002/diff/1/Source/devtools/protocol.json#newcode4522 Source/devtools/protocol.json:4522: { "name": "repeatCount", "type": "integer", "optional": true, "description": "The ...
5 years, 4 months ago (2015-08-18 09:50:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296993002/1
5 years, 4 months ago (2015-08-18 10:44:22 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 11:43:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200723

Powered by Google App Engine
This is Rietveld 408576698