Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: sdk/lib/async/future_impl.dart

Issue 1296973002: Revert "Don't zone-register async callbacks for every await call in the VM." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/symbols.h ('k') | tests/lib/async/async_await_zones_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/future_impl.dart
diff --git a/sdk/lib/async/future_impl.dart b/sdk/lib/async/future_impl.dart
index 35dfd1194f052403843fff9fef9fef1ebcaf706e..9fa1e57090e2583c3485efbd6d9f6a41f5f16da6 100644
--- a/sdk/lib/async/future_impl.dart
+++ b/sdk/lib/async/future_impl.dart
@@ -175,7 +175,6 @@ class _Future<T> implements Future<T> {
*/
var _resultOrListeners;
- // This constructor is used by async/await.
_Future();
/// Valid types for value: `T` or `Future<T>`.
@@ -214,7 +213,7 @@ class _Future<T> implements Future<T> {
return _thenNoZoneRegistration(f, onError);
}
- // This method is used by async/await.
+ // This function is used by async/await.
Future _thenNoZoneRegistration(f(T value), Function onError) {
_Future result = new _Future();
_addListener(new _FutureListener.then(result, f, onError));
@@ -257,7 +256,6 @@ class _Future<T> implements Future<T> {
return _resultOrListeners;
}
- // This method is used by async/await.
void _setValue(T value) {
assert(!_isComplete); // But may have a completion pending.
_state = _VALUE;
« no previous file with comments | « runtime/vm/symbols.h ('k') | tests/lib/async/async_await_zones_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698