Source/core/compositing/DisplayListCompositingBuilder.cpp - Issue 1296963002: Put transform tree building in DisplayItemPropertyTreeBuilder.

Side by Side Diff: Source/core/compositing/DisplayListCompositingBuilder.cpp

Issue 1296963002: Put transform tree building in DisplayItemPropertyTreeBuilder. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove unused include. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | Source/platform/blink_platform.gypi » ('j') | Source/platform/graphics/paint/DisplayItemClipTree.cpp » ('J')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "config.h"	5 #include "config.h"

6 #include "core/compositing/DisplayListCompositingBuilder.h"	6 #include "core/compositing/DisplayListCompositingBuilder.h"

7	7

8 #include "platform/graphics/paint/DisplayItemTransformTreeBuilder.h"	8 #include "platform/graphics/paint/DisplayItemPropertyTreeBuilder.h"

9	9

10 namespace blink {	10 namespace blink {

11	11

12 void DisplayListCompositingBuilder::build(CompositedDisplayList& compositedDispl ayList)	12 void DisplayListCompositingBuilder::build(CompositedDisplayList& compositedDispl ayList)

13 {	13 {

14 // TODO(pdr): Properly implement simple layer compositing here.	14 // TODO(pdr): Properly implement simple layer compositing here.

15 // See: https://docs.google.com/document/d/1qF7wpO_lhuxUO6YXKZ3CJuXi0grcb5gK ZJBBgnoTd0k/view	15 // See: https://docs.google.com/document/d/1qF7wpO_lhuxUO6YXKZ3CJuXi0grcb5gK ZJBBgnoTd0k/view

16	16

17 DisplayItemTransformTreeBuilder transformTreeBuilder;	17 DisplayItemPropertyTreeBuilder treeBuilder;

18 for (const auto& displayItem : m_displayItemList.displayItems())	18 for (const auto& displayItem : m_displayItemList.displayItems())

19 transformTreeBuilder.processDisplayItem(displayItem);	19 treeBuilder.processDisplayItem(displayItem);

20 compositedDisplayList.transformTree = transformTreeBuilder.releaseTransformT ree();	20 compositedDisplayList.transformTree = treeBuilder.releaseTransformTree();

	21 // TODO(pdr, jbroman): Also release other trees, and use range records to
	pdr. 2015/08/17 22:25:07 Nit: TODO(jbroman) We just use the person who add Nit: TODO(jbroman) We just use the person who added the todo now, but it doesn't mean you're on the hook for this. jbroman 2015/08/17 23:57:19 That's not what the code style says, nor what I wa That's not what the code style says, nor what I was told when I started at Google. https://www.chromium.org/blink/coding-style -> http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#TODO_Comments says "TODOs should include the string TODO in all caps, followed by the name, e-mail address, or other identifier of the person with the best context about the problem referenced by the TODO." My understanding is that it's supposed to be more "who knows what this means" than "who added it" or "who should do it". I can change it to just TODO(jbroman) if you prefer, but I'm unconvinced that I'm only allowed to write TODO(jbroman). pdr. 2015/08/18 04:31:41 I re-read the recent thread and you're correct. Di Show quoted text On 2015/08/17 at 23:57:19, jbroman wrote: > That's not what the code style says, nor what I was told when I started at Google. > > https://www.chromium.org/blink/coding-style -> http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#TODO_Comments > > says "TODOs should include the string TODO in all caps, followed by the name, e-mail address, or other identifier of the person with the best context about the problem referenced by the TODO." > > My understanding is that it's supposed to be more "who knows what this means" than "who added it" or "who should do it". > > I can change it to just TODO(jbroman) if you prefer, but I'm unconvinced that I'm only allowed to write TODO(jbroman). I re-read the recent thread and you're correct. Disregard!
	22 // construct simple layers.

21 }	23 }

22	24

23 } // namespace blink	25 } // namespace blink

OLD	NEW