Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1296943003: Presentation API: PresentationRequest.start() requires user gesture. (Closed)

Created:
5 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 4 months ago
Reviewers:
whywhat
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Presentation API: PresentationRequest.start() requires user gesture. Allowing PresentationRequest.start() to be called without user gesture might lead to a confusion regarding the UI: it should show a picker and usually such flow have to be started with a user gesture. BUG=521590 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
A LayoutTests/presentation/presentationrequest.html View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/modules/presentation/PresentationRequest.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mlamouri (slow - plz ping)
5 years, 4 months ago (2015-08-17 14:35:59 UTC) #2
whywhat
lgtm
5 years, 4 months ago (2015-08-17 15:20:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296943003/1
5 years, 4 months ago (2015-08-17 15:20:26 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 16:24:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200650

Powered by Google App Engine
This is Rietveld 408576698