Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1296883005: Disable GitBranchCheck on commit presubmit (Closed)

Created:
5 years, 4 months ago by agable
Modified:
5 years, 4 months ago
CC:
native-client-reviews_googlegroups.com, Derek Schuff
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M PRESUBMIT.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
agable
5 years, 4 months ago (2015-08-18 20:06:09 UTC) #1
Peter Mayo
lgtm
5 years, 4 months ago (2015-08-18 20:38:19 UTC) #2
Mark Seaborn
LGTM. Note that these PNaCl Git repos aren't on the CQ.
5 years, 4 months ago (2015-08-18 20:54:35 UTC) #3
agable
On 2015/08/18 at 20:54:35, mseaborn wrote: > LGTM. Note that these PNaCl Git repos aren't ...
5 years, 4 months ago (2015-08-19 00:11:46 UTC) #4
agable
Committed patchset #1 (id:1) manually as 37d99039d067f03386509c49beb349ba951708b3 (presubmit successful).
5 years, 4 months ago (2015-08-19 00:26:11 UTC) #5
native-client-reviews_googlegroups.com
Obviously you already have, but no problem :) On Tue, Aug 18, 2015, 5:26 PM ...
5 years, 4 months ago (2015-08-19 02:50:27 UTC) #6
agable
5 years, 4 months ago (2015-08-19 15:27:59 UTC) #7
Message was sent while issue was closed.
Actually added myself temporarily to nacl-contributors, which I felt less
bad about.

On Tue, Aug 18, 2015, 7:50 PM Derek Schuff <dschuff@google.com> wrote:

> Obviously you already have, but no problem :)
>
> On Tue, Aug 18, 2015, 5:26 PM agable@chromium.org via
> codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com>
> wrote:
>
>> Committed patchset #1 (id:1) manually as
>> 37d99039d067f03386509c49beb349ba951708b3 (presubmit successful).
>>
>> https://codereview.chromium.org/1296883005/
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

Powered by Google App Engine
This is Rietveld 408576698