Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1296863003: Reduce the number of MetricsData protos to put in each request. (Closed)

Created:
5 years, 4 months ago by dsansome
Modified:
5 years, 4 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Reduce the number of MetricsData protos to put in each request. Large metrics collections from mastermon were being dropped for some reason after the switch to pubsub. BUG=510602 Committed: https://chromium.googlesource.com/infra/infra/+/764fa54893a3e0d458bf7a484587ddd4a8ecb689

Patch Set 1 #

Patch Set 2 : Fix the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M infra_libs/ts_mon/interface.py View 1 chunk +1 line, -1 line 0 comments Download
M infra_libs/ts_mon/test/interface_test.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dsansome
5 years, 4 months ago (2015-08-17 08:38:06 UTC) #2
Sergey Berezin
LGTM, and I added a link to a relevant bug. Thanks!
5 years, 4 months ago (2015-08-17 23:57:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296863003/1
5 years, 4 months ago (2015-08-18 01:53:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: infra_tester on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/builds/2748)
5 years, 4 months ago (2015-08-18 01:58:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296863003/20001
5 years, 4 months ago (2015-08-18 03:09:50 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 03:12:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/764fa54893a3e0d458bf7a484587d...

Powered by Google App Engine
This is Rietveld 408576698