Fix a couple of gcc 4.8 warnings in tcmalloc.

Fix a couple of gcc 4.8 warnings in tcmalloc.

These warning showed up for me when trying to build
chromium using the gcc 4.8 ARM cross compiler in
Ubuntu/saucy.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247817

[jar (doing other things), 2014-01-29 02:33:12]

https://codereview.chromium.org/129683002/diff/100001/third_party/tcmalloc/ch...
File third_party/tcmalloc/chromium/src/deep-heap-profile.cc (left):

https://codereview.chromium.org/129683002/diff/100001/third_party/tcmalloc/ch...
third_party/tcmalloc/chromium/src/deep-heap-profile.cc:131:
static_cast<int>(getpid()));
This looks like a bug.  How about fixing it with a %d to print the pid?

[Dai Mikurube (NOT FULLTIME), 2014-01-29 03:24:12]

Thanks for working on it.

https://codereview.chromium.org/129683002/diff/100001/third_party/tcmalloc/RE...
File third_party/tcmalloc/README.chromium (right):

https://codereview.chromium.org/129683002/diff/100001/third_party/tcmalloc/RE...
third_party/tcmalloc/README.chromium:95: - Fix sprintf formatting warning in
MaybeDumpProfileLocked
deep-heap-profile is actually a Chromium-specific extension, so it's not
mandatory to describe it in README.chromium.

https://codereview.chromium.org/129683002/diff/100001/third_party/tcmalloc/ch...
File third_party/tcmalloc/chromium/src/deep-heap-profile.cc (left):

https://codereview.chromium.org/129683002/diff/100001/third_party/tcmalloc/ch...
third_party/tcmalloc/chromium/src/deep-heap-profile.cc:131:
static_cast<int>(getpid()));
On 2014/01/29 02:33:12, jar wrote:
> This looks like a bug.  How about fixing it with a %d to print the pid?

Ah, yes. It's my bug. Thanks for working on it, Sam.

It doesn't need pid since /proc/kpagecount is kernel-level memory info., not
process memory info.

sbc@'s fix is correct, but just using "/proc/kpagecount" directly in open()
might be better.

[Dai Mikurube (NOT FULLTIME), 2014-01-29 03:37:29]

https://codereview.chromium.org/129683002/diff/100001/third_party/tcmalloc/RE...
File third_party/tcmalloc/README.chromium (right):

https://codereview.chromium.org/129683002/diff/100001/third_party/tcmalloc/RE...
third_party/tcmalloc/README.chromium:95: - Fix sprintf formatting warning in
MaybeDumpProfileLocked
On 2014/01/29 03:24:13, Dai Mikurube wrote:
> deep-heap-profile is actually a Chromium-specific extension, so it's not
> mandatory to describe it in README.chromium.

Oops, sorry, this message is for heap-profiler.cc. But finally, the original
gperftools has already been fixed. They now have no difference from your fix. :)
https://code.google.com/p/gperftools/source/diff?spec=svne54971d58641853a9515...

[Sam Clegg, 2014-01-29 16:32:31]

On 2014/01/29 03:37:29, Dai Mikurube wrote:
>
https://codereview.chromium.org/129683002/diff/100001/third_party/tcmalloc/RE...
> File third_party/tcmalloc/README.chromium (right):
> 
>
https://codereview.chromium.org/129683002/diff/100001/third_party/tcmalloc/RE...
> third_party/tcmalloc/README.chromium:95: - Fix sprintf formatting warning in
> MaybeDumpProfileLocked
> On 2014/01/29 03:24:13, Dai Mikurube wrote:
> > deep-heap-profile is actually a Chromium-specific extension, so it's not
> > mandatory to describe it in README.chromium.
> 
> Oops, sorry, this message is for heap-profiler.cc. But finally, the original
> gperftools has already been fixed. They now have no difference from your fix.
:)
>
https://code.google.com/p/gperftools/source/diff?spec=svne54971d58641853a9515...

Do is this change OK to land, or do you want to pull in a new upstream version?

[jar (doing other things), 2014-01-29 17:34:12]

lgtm

[commit-bot: I haz the power, 2014-01-29 17:37:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/129683002/100001

[commit-bot: I haz the power, 2014-01-30 03:34:56]

Change committed as 247817