Issue 1296803004: [Line Layout API] Use LineLayoutItem consistently in RootInlineBox::childRemoved

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1296803004: [Line Layout API] Use LineLayoutItem consistently in RootInlineBox::childRemoved (Closed)

Created:
5 years, 4 months ago by pilgrim_google

Modified:
5 years, 4 months ago

Reviewers:
leviw_travelin_and_unemployed, jsbell, ojan

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

[Line Layout API] Use LineLayoutItem consistently in RootInlineBox::childRemoved The class has m_lineBreakObj, which has already been converted to the new API. This CL updates the childRemoved method to use box->lineLayoutItem() for comparisons to m_lineBreakObj and for iterating. BUG=499321 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200841

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/layout/line/RootInlineBox.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296803004/1

5 years, 4 months ago (2015-08-19 17:57:32 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-19 19:02:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200841

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages