Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1296803002: Fix -Woverloaded-virtual warnings in ICU. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix -Woverloaded-virtual warnings in ICU. 1. In Win32NumberFormat, rename the private format() method to variadicFormat(). It's just an implementation detail of the class. Fixes: ..\..\third_party\icu\source\i18n/winnmfmt.h(146,20) : error(clang): 'icu_54::Win32NumberFormat::format' hides overloaded virtual functions [-Werror,-Woverloaded-virtual] UnicodeString &format(int32_t numDigits, UnicodeString &appendTo, const wchar_t *format, ...) const; ^ ..\..\third_party\icu\source\i18n\unicode/numfmt.h(255,28) : note(clang): hidden overloaded virtual function 'icu_54::NumberFormat::format' declared here: different number of parameters (4 vs 3) virtual UnicodeString& format(const Formattable& obj, ^ ... 2. In Win32DateFormat, remove the two-argument format() function that just forwards to the base class. (If this happens to produce compile errors, the function should be replaced by `using Win32DateFormat::format(UDate, UnicodeString&) const;`) Fixes: ..\..\third_party\icu\source\i18n/windtfmt.h(55,20) : error(clang): 'icu_54::Win32DateFormat::format' hides overloaded virtual functions [-Werror,-Woverloaded-virtual] UnicodeString& format(UDate date, UnicodeString& appendTo) const; ^ ..\..\third_party\icu\source\i18n\unicode/datefmt.h(240,28) : note(clang): hidden overloaded virtual function 'icu_54::DateFormat::format' declared here: different number of parameters (4 vs 2) virtual UnicodeString& format(const Formattable& obj, ^ ... BUG=505301 R=jshin@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/80ac4c39a5a4fc7fa8ee9dc6b6c057b8b24449e9

Patch Set 1 #

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -11 lines) Patch
M README.chromium View 1 1 chunk +3 lines, -0 lines 0 comments Download
A patches/woverloaded-virtual.patch View 1 1 chunk +74 lines, -0 lines 0 comments Download
M source/i18n/windtfmt.h View 2 chunks +0 lines, -6 lines 0 comments Download
M source/i18n/winnmfmt.h View 1 chunk +1 line, -1 line 0 comments Download
M source/i18n/winnmfmt.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Maybe you could upstream this patch?
5 years, 4 months ago (2015-08-17 23:54:27 UTC) #2
jungshik at Google
On 2015/08/17 23:54:27, Nico wrote: > Maybe you could upstream this patch? Yeah, I'll if ...
5 years, 4 months ago (2015-08-18 00:01:28 UTC) #3
Nico
Committed patchset #2 (id:20001) manually as 80ac4c39a5a4fc7fa8ee9dc6b6c057b8b24449e9 (presubmit successful).
5 years, 4 months ago (2015-08-18 00:02:58 UTC) #4
jungshik at Google
5 years, 3 months ago (2015-08-25 20:48:24 UTC) #5
Message was sent while issue was closed.
On 2015/08/18 00:02:58, Nico wrote:
> Committed patchset #2 (id:20001) manually as
> 80ac4c39a5a4fc7fa8ee9dc6b6c057b8b24449e9 (presubmit successful).

Upstreamed along with the patch : http://bugs.icu-project.org/trac/ticket/11867

Powered by Google App Engine
This is Rietveld 408576698