Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1296773002: clang/win: Enable -Woverloaded-virtual globally. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn too Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 1031 matching lines...) Expand 10 before | Expand all | Expand 10 after
1042 if (is_linux) { 1042 if (is_linux) {
1043 # Don't warn about ignoring the return value from e.g. close(). This is 1043 # Don't warn about ignoring the return value from e.g. close(). This is
1044 # off by default in some gccs but on by default in others. BSD systems do 1044 # off by default in some gccs but on by default in others. BSD systems do
1045 # not support this option, since they are usually using gcc 4.2.1, which 1045 # not support this option, since they are usually using gcc 4.2.1, which
1046 # does not have this flag yet. 1046 # does not have this flag yet.
1047 cflags += [ "-Wno-unused-result" ] 1047 cflags += [ "-Wno-unused-result" ]
1048 } 1048 }
1049 1049
1050 if (is_clang) { 1050 if (is_clang) {
1051 cflags += [ 1051 cflags += [
1052 # TODO(mgiuca): Move this suppression into individual third-party
1053 # libraries as required. http://crbug.com/505301.
1054 "-Wno-overloaded-virtual",
1055
1056 # TODO(thakis): Move this suppression into individual third-party 1052 # TODO(thakis): Move this suppression into individual third-party
1057 # libraries as required. http://crbug.com/505316. 1053 # libraries as required. http://crbug.com/505316.
1058 "-Wno-unused-function", 1054 "-Wno-unused-function",
1059 1055
1060 # Lots of third-party libraries have unused variables. Instead of 1056 # Lots of third-party libraries have unused variables. Instead of
1061 # suppressing them individually, we just blanket suppress them here. 1057 # suppressing them individually, we just blanket suppress them here.
1062 "-Wno-unused-variable", 1058 "-Wno-unused-variable",
1063 ] 1059 ]
1064 } 1060 }
1065 1061
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
1331 cflags += [ "-gsplit-dwarf" ] 1327 cflags += [ "-gsplit-dwarf" ]
1332 } 1328 }
1333 } 1329 }
1334 } 1330 }
1335 1331
1336 config("no_symbols") { 1332 config("no_symbols") {
1337 if (!is_win) { 1333 if (!is_win) {
1338 cflags = [ "-g0" ] 1334 cflags = [ "-g0" ]
1339 } 1335 }
1340 } 1336 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698