Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: build/common.gypi

Issue 1296773002: clang/win: Enable -Woverloaded-virtual globally. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn too Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3125 matching lines...) Expand 10 before | Expand all | Expand 10 after
3136 ['<(chromeos)==1 and >(nacl_untrusted_build)==0', { 3136 ['<(chromeos)==1 and >(nacl_untrusted_build)==0', {
3137 'defines': ['OS_CHROMEOS=1'], 3137 'defines': ['OS_CHROMEOS=1'],
3138 }], 3138 }],
3139 ['enable_wexit_time_destructors==1 and OS!="win"', { 3139 ['enable_wexit_time_destructors==1 and OS!="win"', {
3140 # TODO: Enable on Windows too, http://crbug.com/404525 3140 # TODO: Enable on Windows too, http://crbug.com/404525
3141 'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']}, 3141 'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
3142 }], 3142 }],
3143 ['chromium_code==0', { 3143 ['chromium_code==0', {
3144 'variables': { 3144 'variables': {
3145 'clang_warning_flags': [ 3145 'clang_warning_flags': [
3146 # TODO(mgiuca): Move this suppression into individual third-party
3147 # libraries as required. http://crbug.com/505301.
3148 '-Wno-overloaded-virtual',
3149 # TODO(thakis): Move this suppression into individual third-party 3146 # TODO(thakis): Move this suppression into individual third-party
3150 # libraries as required. http://crbug.com/505316. 3147 # libraries as required. http://crbug.com/505316.
3151 '-Wno-unused-function', 3148 '-Wno-unused-function',
3152 # Lots of third-party libraries have unused variables. Instead of 3149 # Lots of third-party libraries have unused variables. Instead of
3153 # suppressing them individually, we just blanket suppress them here. 3150 # suppressing them individually, we just blanket suppress them here.
3154 '-Wno-unused-variable', 3151 '-Wno-unused-variable',
3155 ], 3152 ],
3156 }, 3153 },
3157 'conditions': [ 3154 'conditions': [
3158 [ 'os_posix==1 and OS!="mac" and OS!="ios"', { 3155 [ 'os_posix==1 and OS!="mac" and OS!="ios"', {
(...skipping 3159 matching lines...) Expand 10 before | Expand all | Expand 10 after
6318 # settings in target dicts. SYMROOT is a special case, because many other 6315 # settings in target dicts. SYMROOT is a special case, because many other
6319 # Xcode variables depend on it, including variables such as 6316 # Xcode variables depend on it, including variables such as
6320 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6317 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6321 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6318 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6322 # files to appear (when present) in the UI as actual files and not red 6319 # files to appear (when present) in the UI as actual files and not red
6323 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6320 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6324 # and therefore SYMROOT, needs to be set at the project level. 6321 # and therefore SYMROOT, needs to be set at the project level.
6325 'SYMROOT': '<(DEPTH)/xcodebuild', 6322 'SYMROOT': '<(DEPTH)/xcodebuild',
6326 }, 6323 },
6327 } 6324 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698