Issue 1296763003: Rename state -> nextState in DocumentLifecycle::canAdvanceTo and co.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1296763003: Rename state -> nextState in DocumentLifecycle::canAdvanceTo and co. (Closed)

Created:
5 years, 4 months ago by pdr.

Modified:
5 years, 4 months ago

Reviewers:
esprehn

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Rename state -> nextState in DocumentLifecycle::canAdvanceTo and co. DocumentLifecycle::canAdvanceTo has a large switch statement which isn't immediately clear if you fail to notice that "state" is not the current state. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200601

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -52 lines)			Patch
	M	Source/core/dom/DocumentLifecycle.cpp	View		1 chunk	+52 lines, -52 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296763003/1

5 years, 4 months ago (2015-08-15 03:17:28 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-15 05:56:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200601

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages